git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [StGit PATCH] Import git show output easily
@ 2009-09-02 17:50 Catalin Marinas
  2009-09-02 20:51 ` Gustav Hållberg
  0 siblings, 1 reply; 3+ messages in thread
From: Catalin Marinas @ 2009-09-02 17:50 UTC (permalink / raw)
  To: Karl Hasselström, git

This patch modifies the import command to check for standard 'git show'
output and parse it accordingly.

Signed-off-by: Catalin Marinas <catalin.marinas@gmail.com>
---
 stgit/commands/common.py |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/stgit/commands/common.py b/stgit/commands/common.py
index d38d263..0d39148 100644
--- a/stgit/commands/common.py
+++ b/stgit/commands/common.py
@@ -355,6 +355,7 @@ def __parse_description(descr):
 
     lasthdr = 0
     end = len(descr_lines)
+    descr_strip = 0
 
     # Parse the patch header
     for pos in range(0, end):
@@ -374,12 +375,16 @@ def __parse_description(descr):
         if subject:
             break
         # get the subject
-        subject = descr_lines[pos]
+        subject = descr_lines[pos][descr_strip:]
+        if re.match('commit [\da-f]{40}$', subject):
+            # 'git show' output, look for the real subject
+            subject = ''
+            descr_strip = 4
         lasthdr = pos + 1
 
     # get the body
     if lasthdr < end:
-        body = reduce(lambda x, y: x + '\n' + y, descr_lines[lasthdr:], '')
+        body = '\n' + '\n'.join(l[descr_strip:] for l in descr_lines[lasthdr:])
 
     return (subject + body, authname, authemail, authdate)
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [StGit PATCH] Import git show output easily
  2009-09-02 17:50 [StGit PATCH] Import git show output easily Catalin Marinas
@ 2009-09-02 20:51 ` Gustav Hållberg
  2009-09-02 20:54   ` Catalin Marinas
  0 siblings, 1 reply; 3+ messages in thread
From: Gustav Hållberg @ 2009-09-02 20:51 UTC (permalink / raw)
  To: Catalin Marinas; +Cc: Karl Hasselström, git

Somewhat related:

It would really rock if stg import could handle the regular patch "-p<N>" flag.
In particular, I miss -p0 as some broken versioning systems default to
such output.

- Gustav

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [StGit PATCH] Import git show output easily
  2009-09-02 20:51 ` Gustav Hållberg
@ 2009-09-02 20:54   ` Catalin Marinas
  0 siblings, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2009-09-02 20:54 UTC (permalink / raw)
  To: Gustav Hållberg; +Cc: Karl Hasselström, git

2009/9/2 Gustav Hållberg <gustav@gmail.com>:
> It would really rock if stg import could handle the regular patch "-p<N>" flag.
> In particular, I miss -p0 as some broken versioning systems default to
> such output.

It's probably just a matter of passing the right flag to git-apply.
I'll try to have a look before -rc3.

-- 
Catalin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-09-02 20:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-02 17:50 [StGit PATCH] Import git show output easily Catalin Marinas
2009-09-02 20:51 ` Gustav Hållberg
2009-09-02 20:54   ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).