From: Pascal Obry <pascal@obry.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: gitzilla@gmail.com, Steffen Prohaska <prohaska@zib.de>,
git@vger.kernel.org
Subject: Re: 026fa0d5ad Breaks installs with absolue $(gitexecdir) and $(template_dir) variables using older GNU makes
Date: Thu, 5 Feb 2009 08:57:22 +0100 [thread overview]
Message-ID: <a2633edd0902042357s35ab8fe7g59cb3ef109e9b0bb@mail.gmail.com> (raw)
In-Reply-To: <7vvdrpgvzl.fsf@gitster.siamese.dyndns.org>
Junio,
> Does your patch address the lack of $(abspath) in older GNU make?
Don't think so.
> Regardless, I think your patch to config.mak is independently good,
> because the way Makefile defines these directories is without the trailing
> slash, and it would be better to be consistent.
Right, better to have no slash ending directories to avoid double
slashes in $(dir)/file.c.
Pascal.
--
--|------------------------------------------------------
--| Pascal Obry Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--| http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595
next prev parent reply other threads:[~2009-02-05 7:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 18:24 026fa0d5ad Breaks installs with absolue $(gitexecdir) and $(template_dir) variables using older GNU makes A Large Angry SCM
2009-02-05 7:04 ` Junio C Hamano
2009-02-05 7:13 ` Steffen Prohaska
2009-02-05 7:35 ` Junio C Hamano
2009-02-05 7:38 ` Pascal Obry
2009-02-05 7:53 ` Junio C Hamano
2009-02-05 7:57 ` Pascal Obry [this message]
2009-02-05 8:01 ` Junio C Hamano
2009-02-05 7:44 ` Junio C Hamano
2009-02-05 8:18 ` [PATCH] Makefile: fix misdetection of relative pathnames Junio C Hamano
2009-02-05 12:27 ` Johannes Sixt
2009-02-05 17:19 ` Junio C Hamano
2009-02-05 22:16 ` A Large Angry SCM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2633edd0902042357s35ab8fe7g59cb3ef109e9b0bb@mail.gmail.com \
--to=pascal@obry.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitzilla@gmail.com \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).