From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pascal Obry Subject: Re: 026fa0d5ad Breaks installs with absolue $(gitexecdir) and $(template_dir) variables using older GNU makes Date: Thu, 5 Feb 2009 08:57:22 +0100 Message-ID: References: <4985E8E1.90303@gmail.com> <7v63jpibe8.fsf@gitster.siamese.dyndns.org> <7vvdrpgvzl.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: gitzilla@gmail.com, Steffen Prohaska , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Thu Feb 05 08:58:52 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LUz8N-0007uT-Pe for gcvg-git-2@gmane.org; Thu, 05 Feb 2009 08:58:52 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbZBEH50 (ORCPT ); Thu, 5 Feb 2009 02:57:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753511AbZBEH5Z (ORCPT ); Thu, 5 Feb 2009 02:57:25 -0500 Received: from mail-fx0-f20.google.com ([209.85.220.20]:46998 "EHLO mail-fx0-f20.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036AbZBEH5Z (ORCPT ); Thu, 5 Feb 2009 02:57:25 -0500 Received: by fxm13 with SMTP id 13so140045fxm.13 for ; Wed, 04 Feb 2009 23:57:23 -0800 (PST) Received: by 10.223.124.75 with SMTP id t11mr52731far.73.1233820642295; Wed, 04 Feb 2009 23:57:22 -0800 (PST) In-Reply-To: <7vvdrpgvzl.fsf@gitster.siamese.dyndns.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Junio, > Does your patch address the lack of $(abspath) in older GNU make? Don't think so. > Regardless, I think your patch to config.mak is independently good, > because the way Makefile defines these directories is without the trailing > slash, and it would be better to be consistent. Right, better to have no slash ending directories to avoid double slashes in $(dir)/file.c. Pascal. -- --|------------------------------------------------------ --| Pascal Obry Team-Ada Member --| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE --|------------------------------------------------------ --| http://www.obry.net --| "The best way to travel is by means of imagination" --| --| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595