git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH v2 3/7] check-ref-format --branch: give Porcelain a way to grok branch shorthand
Date: Mon, 23 Mar 2009 00:58:36 -0700	[thread overview]
Message-ID: <a31dca0393fefae894b7a155ae24000107bcc383.1237791716.git.gitster@pobox.com> (raw)
In-Reply-To: <a552de75eb01f78046feaf7dc88e5e4833624ad5.1237791716.git.gitster@pobox.com>
In-Reply-To: <cover.1237791716.git.gitster@pobox.com>

The command may not be the best place to add this new feature, but

    $ git check-ref-format --branch "@{-1}"

allows Porcelains to figure out what branch you were on before the last
branch switching.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Documentation/git-check-ref-format.txt |   12 ++++++++++++
 builtin-check-ref-format.c             |   10 ++++++++++
 2 files changed, 22 insertions(+), 0 deletions(-)

diff --git a/Documentation/git-check-ref-format.txt b/Documentation/git-check-ref-format.txt
index 034223c..51579f6 100644
--- a/Documentation/git-check-ref-format.txt
+++ b/Documentation/git-check-ref-format.txt
@@ -7,7 +7,9 @@ git-check-ref-format - Make sure ref name is well formed
 
 SYNOPSIS
 --------
+[verse]
 'git check-ref-format' <refname>
+'git check-ref-format' [--branch] <branchname-shorthand>
 
 DESCRIPTION
 -----------
@@ -49,6 +51,16 @@ refname expressions (see linkgit:git-rev-parse[1]).  Namely:
   It may also be used to select a specific object such as with
   'git-cat-file': "git cat-file blob v1.3.3:refs.c".
 
+With the `--branch` option, it expands a branch name shorthand and
+prints the name of the branch the shorthand refers to.
+
+EXAMPLE
+-------
+
+git check-ref-format --branch @{-1}::
+
+Print the name of the previous branch.
+
 
 GIT
 ---
diff --git a/builtin-check-ref-format.c b/builtin-check-ref-format.c
index 701de43..39db6cb 100644
--- a/builtin-check-ref-format.c
+++ b/builtin-check-ref-format.c
@@ -5,9 +5,19 @@
 #include "cache.h"
 #include "refs.h"
 #include "builtin.h"
+#include "strbuf.h"
 
 int cmd_check_ref_format(int argc, const char **argv, const char *prefix)
 {
+	if (argc == 3 && !strcmp(argv[1], "--branch")) {
+		struct strbuf sb = STRBUF_INIT;
+		strbuf_branchname(&sb, argv[2]);
+		strbuf_splice(&sb, 0, 0, "refs/heads/", 11);
+		if (check_ref_format(sb.buf))
+			die("'%s' is not a valid branch name", argv[2]);
+		printf("%s\n", sb.buf + 11);
+		exit(0);
+	}
 	if (argc != 2)
 		usage("git check-ref-format refname");
 	return !!check_ref_format(argv[1]);
-- 
1.6.2.1.349.ga64c

  reply	other threads:[~2009-03-23  8:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-23  7:58 [PATCH v2 0/7] Clean up interpret_nth_last_branch feature Junio C Hamano
2009-03-23  7:58 ` [PATCH v2 1/7] Rename interpret/substitute nth_last_branch functions Junio C Hamano
2009-03-23  7:58   ` [PATCH v2 2/7] strbuf_branchname(): a wrapper for branch name shorthands Junio C Hamano
2009-03-23  7:58     ` Junio C Hamano [this message]
2009-03-23  7:58       ` [PATCH v2 4/7] Fix branch -m @{-1} newname Junio C Hamano
2009-03-23  7:58         ` [PATCH v2 5/7] strbuf_check_branch_ref(): a helper to check a refname for a branch Junio C Hamano
2009-03-23  7:58           ` [PATCH v2 6/7] check_ref_format(): tighten refname rules Junio C Hamano
2009-03-23  7:58             ` [PATCH v2 7/7] checkout -: make "-" to mean "previous branch" everywhere Junio C Hamano
2009-03-23 13:59             ` [PATCH v2 6/7] check_ref_format(): tighten refname rules Shawn O. Pearce
2009-03-23 16:03               ` Junio C Hamano
2009-03-23  8:10 ` [PATCH v2 0/7] Clean up interpret_nth_last_branch feature Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a31dca0393fefae894b7a155ae24000107bcc383.1237791716.git.gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).