git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: phillip.wood@dunelm.org.uk,
	Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: Jeff King <peff@peff.net>,
	Phillip Wood via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] rebase -i: ignore signals when forking subprocesses
Date: Mon, 11 Sep 2023 11:14:31 +0100	[thread overview]
Message-ID: <a37a0f11-0723-4964-a187-54d960615d79@gmail.com> (raw)
In-Reply-To: <80eb7631-e5c0-497e-b2a9-b1f8c8a4a306@gmail.com>

On 11/09/2023 11:00, Phillip Wood wrote:
> There is an inevitable race between wait() returning and calling 
> signal() to restore the handlers for SIGINT and SIGQUIT,

In principle if we installed a signal handler to set a flag if a signal 
is received while calling wait() and then once wait() returns 
successfully see if the child was killed we can tell if the signal was 
received while the child was alive. In practice if the child is catching 
SIGINT or SIGQUIT we cannot rely on it re-raising the signal so that 
wont work.

Best Wishes

Phillip


  reply	other threads:[~2023-09-11 21:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 10:03 [PATCH] rebase -i: ignore signals when forking subprocesses Phillip Wood via GitGitGadget
2023-09-07 12:57 ` Johannes Schindelin
2023-09-08 10:02   ` Phillip Wood
2023-09-10  8:24     ` Johannes Schindelin
2023-09-07 21:06 ` Jeff King
2023-09-08  9:59   ` Phillip Wood
2023-09-08 13:11     ` Phillip Wood
2023-09-10 10:05     ` Oswald Buddenhagen
2023-09-11 10:00       ` Phillip Wood
2023-09-11 10:14         ` Phillip Wood [this message]
2023-09-11 10:32           ` Oswald Buddenhagen
2023-09-13 15:33             ` Phillip Wood
2023-09-13 16:40               ` Oswald Buddenhagen
2023-09-14  9:56     ` Jeff King
2023-09-14 13:50       ` Phillip Wood
2023-09-07 21:16 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a37a0f11-0723-4964-a187-54d960615d79@gmail.com \
    --to=phillip.wood123@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=oswald.buddenhagen@gmx.de \
    --cc=peff@peff.net \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).