git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
To: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] notes: remove trailing whitespace from editor template
Date: Sun, 25 May 2025 22:46:35 +0200	[thread overview]
Message-ID: <a3c252cf-dec3-4b2c-828e-f25e48853585@app.fastmail.com> (raw)
In-Reply-To: <c59ae2c0c7c8420ec1c5bedb87f28c7f5b573a60.1748122397.git.code@khaugsbakk.name>

On Sat, May 24, 2025, at 23:35, kristofferhaugsbakk@fastmail.com wrote:
> +	test_commit --signoff 23rd &&
> +	GIT_EDITOR="cat >actual" git notes add &&
> +	test_grep ! " $" actual
> +'
> +
>  test_done

Or alternatively I could assert on the whole template:

```
test_expect_success 'git notes add editor template' '
	test_commit --signoff 23rd &&
	cat <<-EOF >expect &&

	#
	# Write/edit the notes for the following object:
	#
	$(git show --stat --no-notes 23rd |
		    git stripspace |
		    git stripspace --comment-lines)
	EOF
	GIT_EDITOR="cat >actual" git notes add &&
	test_cmp expect actual
'
```

-- 
Kristoffer


  reply	other threads:[~2025-05-25 20:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-24 21:35 [PATCH] notes: remove trailing whitespace from editor template kristofferhaugsbakk
2025-05-25 20:46 ` Kristoffer Haugsbakk [this message]
2025-05-26 14:01 ` Phillip Wood
2025-05-26 19:44   ` Kristoffer Haugsbakk
2025-05-27  8:24     ` Phillip Wood
2025-05-27 16:11       ` Kristoffer Haugsbakk
2025-05-27 17:18   ` Junio C Hamano
2025-05-27 17:28     ` Eric Sunshine
2025-05-27 21:21     ` Kristoffer Haugsbakk
2025-05-27 22:22     ` Junio C Hamano
2025-06-02 13:52     ` Phillip Wood
2025-06-03 20:37     ` D. Ben Knoble
2025-06-03 20:46       ` Eric Sunshine
2025-06-09 21:10         ` Kristoffer Haugsbakk
2025-06-09 21:12       ` Kristoffer Haugsbakk
2025-06-10 21:11         ` D. Ben Knoble
2025-06-10 22:55           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3c252cf-dec3-4b2c-828e-f25e48853585@app.fastmail.com \
    --to=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).