git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ryan Flynn <parseerror@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] fix potential infinite loop given large unsigned integer
Date: Sun, 9 Aug 2009 00:41:21 -0400	[thread overview]
Message-ID: <a3f15ee60908082141l7b2134cg5ddcef17c45fc888@mail.gmail.com> (raw)

given n, tried to find i greater than n via i=1, iterate i *= 10.
given n sufficiently close to UINT_MAX this will overflow; which can
produce i==0, which results in an infinite loop. iteratively dividing
n /= 10 does not have this problem, and though division is slower than
multiplication this only runs once per `git format-patch
--cover-letter`

Signed-off-by: pizza <parseerror@gmail.com>
---
 log-tree.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/log-tree.c b/log-tree.c
index 6f73c17..53a1bd2 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -160,9 +160,9 @@ static void append_signoff(struct strbuf *sb,
const char *signoff)

 static unsigned int digits_in_number(unsigned int number)
 {
-       unsigned int i = 10, result = 1;
-       while (i <= number) {
-               i *= 10;
+       unsigned int result = 1;
+       while (number > 9) {
+    number /= 10;
                result++;
        }
        return result;
-- 
1.6.0.4

             reply	other threads:[~2009-08-09  4:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-09  4:41 Ryan Flynn [this message]
2009-08-09  6:19 ` [PATCH] fix potential infinite loop given large unsigned integer Junio C Hamano
2009-08-09  7:38   ` Junio C Hamano
2009-08-09 12:25     ` Erik Faye-Lund
2009-08-10  5:24       ` Christian Couder
2009-08-10 11:12         ` Erik Faye-Lund
2009-08-10 12:24           ` Johannes Schindelin
2009-08-10 16:14             ` Ryan Flynn
2009-08-10 16:17             ` Ryan Flynn
2009-08-10 16:53               ` Johannes Schindelin
2009-08-11  0:55       ` Jeff Epler
2009-08-10  0:23     ` Ryan Flynn
2009-08-10 18:19     ` Tony Finch
2009-08-09 23:16   ` Ryan Flynn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3f15ee60908082141l7b2134cg5ddcef17c45fc888@mail.gmail.com \
    --to=parseerror@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).