From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Flynn Subject: Re: [PATCH] fix potential infinite loop given large unsigned integer Date: Mon, 10 Aug 2009 12:17:40 -0400 Message-ID: References: <7v3a81a13z.fsf@alter.siamese.dyndns.org> <40aa078e0908090525h7b4d6efeh658e2edcfbe16c7e@mail.gmail.com> <200908100724.53345.chriscool@tuxfamily.org> <40aa078e0908100412l3c2afd1bnda9b10aaf1de383f@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Erik Faye-Lund , Christian Couder , Junio C Hamano , git@vger.kernel.org To: Johannes Schindelin X-From: git-owner@vger.kernel.org Mon Aug 10 18:18:06 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1MaXZW-0003pz-8Z for gcvg-git-2@gmane.org; Mon, 10 Aug 2009 18:18:06 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755611AbZHJQRk convert rfc822-to-quoted-printable (ORCPT ); Mon, 10 Aug 2009 12:17:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755584AbZHJQRk (ORCPT ); Mon, 10 Aug 2009 12:17:40 -0400 Received: from mail-vw0-f172.google.com ([209.85.212.172]:52645 "EHLO mail-vw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755460AbZHJQRj convert rfc822-to-8bit (ORCPT ); Mon, 10 Aug 2009 12:17:39 -0400 Received: by vws2 with SMTP id 2so2774216vws.4 for ; Mon, 10 Aug 2009 09:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=B0J+nrc612HkQg1ueT5GRP8LKrgRNtTm3pEURQMAScI=; b=MKR8b9vhV4N+DkGy7fOFE+/zHFEpJhrSlO5F+bTCBZB/tySqg9TvaCONcEdFidwYyD xY5bMWazyDtGMMmhINiCE9MzXKvYvcxgz6mo9efUNHnazUyPEVl/cgKpRU3B81aEg1FK 2aOXAc68VTi82QoEBg91+q/EqDsJbiwuaYYUU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=s2KcC3V3Fc4+/c32Adm6Aslv7aQtS1zWJutUt1za0NyrMl7hYx3Yrkux61GOlLEEzH SybZDfnjvLh8hhSiQVk+yyr0d1glsZPUAmMwlFIPRoBCEKRPxKQDcjMPOxydaQZT3Kmh Uyys5RwCEAAnSvL38uRNd4CxFddWjD6z+OmUc= Received: by 10.220.90.209 with SMTP id j17mr4900697vcm.6.1249921060184; Mon, 10 Aug 2009 09:17:40 -0700 (PDT) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Mon, Aug 10, 2009 at 8:24 AM, Johannes Schindelin wrote: > Hi, > > On Mon, 10 Aug 2009, Erik Faye-Lund wrote: > >> On Mon, Aug 10, 2009 at 7:24 AM, Christian >> Couder wrote: >> >> log10() appears to be C99, but can be emulated on earlier C-versi= ons by >> >> doing #define log10(x) (log(x) / log(10.0)) >> > >> > That would mean linking with -lm? >> >> I guess so. Are we currently trying to avoid linking to the math-par= ts >> of libc? > > Yes. > > I guess we could fix the overflow thing very easily, though: > > static unsigned int digits_of_number(unsigned int number) { > =A0 =A0 =A0 =A0unsigned int result; > =A0 =A0 =A0 =A0for (result =3D 1; number; number /=3D 10, result++) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0; /* do nothing */ > =A0 =A0 =A0 =A0return result; > } > > Ciao, > Dscho > > whoops, actually yours: digits_of_number(1) -> 2