From: Lessley Dennington <lessleydennington@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: "Elijah Newren" <newren@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Taylor Blau" <me@ttaylorr.com>
Subject: ld/sparse-diff-blame, was What's cooking in git.git (Dec 2021, #02; Tue, 7)
Date: Wed, 8 Dec 2021 13:57:59 -0600 [thread overview]
Message-ID: <a4968ff2-17c6-faa8-e9be-0c1880e870dd@gmail.com> (raw)
In-Reply-To: <xmqq8rwv6e0a.fsf@gitster.g>
> * ld/sparse-diff-blame (2021-12-06) 8 commits
> - blame: enable and test the sparse index
> - diff: enable and test the sparse index
> - diff: replace --staged with --cached in t1092 tests
> - repo-settings: prepare_repo_settings only in git repos
> - test-read-cache: set up repo after git directory
> - commit-graph: return if there is no git directory
> - git: ensure correct git directory setup with -h
> - Merge branch 'vd/sparse-reset' into ld/sparse-diff-blame
> (this branch is used by ds/fetch-pull-with-sparse-index; uses vd/sparse-reset.)
>
> Teach diff and blame to work well with sparse index.
>
> Will merge to 'next'?
> source: <pull.1050.v6.git.1638806161.gitgitgadget@gmail.com>
>
This series has been reviewed at different stages by:
Junio C Hamano <gitster@pobox.com>
- Suggested addition of BUG in prepare_repo_settings.
- Suggested --help fix for certain builtins when run outside repos
or with special config settings.
- Suggested using --cached instead of --staged in diff tests.
Elijah Newren <newren@gmail.com>
- Suggested diff commit message cleanup.
- Corrected git commit message typo.
- Corrected comment on blame sparse index tests specifying why
this builtin does not work on files outside the working
directory.
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Suggested lower case first letter in prepare_repo_settings BUG
message.
Taylor Blau <me@ttaylor.com>
- Suggested diff/blame commit description cleanups
- Suggested addition of more diff sparse index test cases
- Suggested cleanup of blame sparse index test cases
I believe all comments have been addressed (either in the form of a
re-roll or a patch or explanation in my reply) and that this branch is
ready to merge to 'next'. I have cc'd all reviewers, though, in case there
was something I missed.
Lessley
next prev parent reply other threads:[~2021-12-08 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 2:12 What's cooking in git.git (Dec 2021, #02; Tue, 7) Junio C Hamano
2021-12-08 4:02 ` Eric Sunshine
2021-12-08 18:05 ` Elijah Newren
2021-12-08 19:57 ` Lessley Dennington [this message]
2021-12-08 20:18 ` ld/sparse-diff-blame, was " Elijah Newren
2021-12-08 21:13 ` Junio C Hamano
2021-12-08 22:58 ` Lessley Dennington
2021-12-09 0:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4968ff2-17c6-faa8-e9be-0c1880e870dd@gmail.com \
--to=lessleydennington@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).