From: Thiago Farina <tfransosi@gmail.com>
To: Johannes Gilger <heipei@hackvalue.de>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Trivial fix: Make all the builtin usage strings to use the same pattern.
Date: Sun, 20 Sep 2009 11:51:02 -0300 [thread overview]
Message-ID: <a4c8a6d00909200751r87fdf83oe92e5a2076b1b527@mail.gmail.com> (raw)
In-Reply-To: <20090920143526.GA22295@dualtron.vpn.rwth-aachen.de>
On Sun, Sep 20, 2009 at 11:35 AM, Johannes Gilger <heipei@hackvalue.de> wrote:
> On 20/09/09 09:17, Thiago Farina wrote:
>> They follow the pattern of file name:
>> File name pattern: builtin-command-name.c
>> Usage string pattern: builtin_command_name_usage
>> [...]
>> -static char const * const archive_usage[] = {
>> +static const char * const archive_usage[] = {
>> "git archive [options] <tree-ish> [path...]",
>> "git archive --list",
>> "git archive --remote <repo> [--exec <cmd>] [options] <tree-ish> [path...]",
> Looks like you missed a spot ;)
The change here is about 'char const *' to 'const char *', to match
with the definition in api-parse-options.txt. :)
Is there a reason for archive do not has a builtin- in it file name?
next prev parent reply other threads:[~2009-09-20 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-20 13:17 [PATCH] Trivial fix: Make all the builtin usage strings to use the same pattern Thiago Farina
2009-09-20 14:35 ` Johannes Gilger
2009-09-20 14:51 ` Thiago Farina [this message]
2009-09-21 15:28 ` Brandon Casey
2009-09-21 20:05 ` Thiago Farina
2009-09-21 16:09 ` Johannes Sixt
2009-09-21 21:39 ` Thiago Farina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4c8a6d00909200751r87fdf83oe92e5a2076b1b527@mail.gmail.com \
--to=tfransosi@gmail.com \
--cc=git@vger.kernel.org \
--cc=heipei@hackvalue.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).