From: Thiago Farina <tfransosi@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Trivial fix: Make all the builtin usage strings to use the same pattern.
Date: Mon, 21 Sep 2009 18:39:45 -0300 [thread overview]
Message-ID: <a4c8a6d00909211439j3638d924xedccd4c2f8702261@mail.gmail.com> (raw)
In-Reply-To: <4AB7A534.2070406@viscovery.net>
On Mon, Sep 21, 2009 at 1:09 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> Thiago Farina schrieb:
>> They follow the pattern of file name:
>> File name pattern: builtin-command-name.c
>> Usage string pattern: builtin_command_name_usage
>
> Well, file names are not so constant: every now and then an external
> command is turned into a builtin (and the filename is changed), and we
> have even seen that a builtin was turned into an external command.
> Moreover, some commands are implemented in the same file, for example 'git
> log' and 'git show'. How about naming the variable after the command name?
> E.g.:
>
> command: git cat-file
> variable: git_cat_file_usage
That sounds good, I will follow this pattern in the next patch. So all
existing builtin_command_name_usage will be changed to
git_command_name_usage, command_name_usage to git_command_name_usage,
etc.
prev parent reply other threads:[~2009-09-21 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-20 13:17 [PATCH] Trivial fix: Make all the builtin usage strings to use the same pattern Thiago Farina
2009-09-20 14:35 ` Johannes Gilger
2009-09-20 14:51 ` Thiago Farina
2009-09-21 15:28 ` Brandon Casey
2009-09-21 20:05 ` Thiago Farina
2009-09-21 16:09 ` Johannes Sixt
2009-09-21 21:39 ` Thiago Farina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4c8a6d00909211439j3638d924xedccd4c2f8702261@mail.gmail.com \
--to=tfransosi@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).