From: Thiago Farina <tfransosi@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] Trivial fix: Make all the usage strings to use the same pattern.
Date: Tue, 22 Sep 2009 16:55:30 -0300 [thread overview]
Message-ID: <a4c8a6d00909221255i2f45e19ex95a13b027886d3e4@mail.gmail.com> (raw)
In-Reply-To: <7vocp2ssv4.fsf@alter.siamese.dyndns.org>
On Tue, Sep 22, 2009 at 4:05 PM, Junio C Hamano <gitster@pobox.com> wrote:
> What does this _fix_?
The answer here is nothing. But I think the benefit is to a have a
pattern, but if it is _not_ desired, I can stop here.
> I see v2 and v3 were posted 15 minutes apart. People need to check both
> to see what changed, and that also adds to the cost.
>
> Please slow down.
I sent the v3 to fix my mistake: api-builtin.txt to api-parse-options.txt
You are right, I have to slow down here.
>
> I do not mean "please slow down working on your patch, and instead spend
> time somewhere else". I mean "please spend more time rre-re-re-reviewing
> what you are going to send." If you did so, externally it would look as
> if you slowed down ;-).
As I said above, I can stop here if this is not a good change.
> Among the topics that are cooking in 'next', at least builtin-commit.c and
> fast-import.c have changes to overlapping areas this huge patch touches.
> At least, exclude the changes to them from this patch, and make patches
> separately for them. That would make the cost of conflict resolution
> slightly smaller. You need to also check with 'pu', but writing this
> response has already made me exceed my git time for today.
If the answer above is yes (I can continue), I will separate it in a
bunch of commits(patches) and I will check more careful before submit
another patch here.
next prev parent reply other threads:[~2009-09-22 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 17:08 [PATCH v3] Trivial fix: Make all the usage strings to use the same pattern Thiago Farina
2009-09-22 19:05 ` Junio C Hamano
2009-09-22 19:55 ` Thiago Farina [this message]
2009-09-23 5:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4c8a6d00909221255i2f45e19ex95a13b027886d3e4@mail.gmail.com \
--to=tfransosi@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).