git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thiago Farina <tfransosi@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stephen Boyd <bebarino@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] ls-tree: migrate to parse-options
Date: Wed, 18 Nov 2009 21:10:02 -0200	[thread overview]
Message-ID: <a4c8a6d00911181510y66338536wb4b51b0df4788e76@mail.gmail.com> (raw)
In-Reply-To: <7veinvcw7w.fsf@alter.siamese.dyndns.org>

On Wed, Nov 18, 2009 at 8:19 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Stephen Boyd <bebarino@gmail.com> writes:
>
>> Junio C Hamano wrote:
>>>
>>> @@ -24,7 +24,7 @@ static int chomp_prefix;
>>>  static const char *ls_tree_prefix;
>>>   static const  char * const ls_tree_usage[] = {
>>> -    "git ls-tree [-d] [-r] [-t] [-l | --long] [-z] [--name-only] [--name-status] [--full-name] [--full-tree] [--abbrev[=<n>]] <tree-ish> [path...]",
>>> +    "git ls-tree <options> <tree-ish> [path...]",
>>>      NULL
>>>  };
>>>
>>
>> Is it [<options>] or [<options>...] or <options> or even
>> <options>... though?
>
> Output from "git grep -e '<option' -- '*.c'" indicates that it
> should be "[<options>]"; thanks for spotting.

$ git grep -e '<option' -- '*.c' | wc -l
4

$ git grep -e '\[options' -- '*.c' | wc -l
42

$ git grep -e '\[<options' -- '*.c' | wc -l
2

Shouldn't be just "[options]"?

      reply	other threads:[~2009-11-18 23:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-14  4:34 [PATCH 0/2] Migrate ls-tree to parse-opts Stephen Boyd
2009-11-14  4:34 ` [PATCH 1/2] t3101: test more ls-tree options Stephen Boyd
2009-11-17  6:21   ` Junio C Hamano
2009-11-17  6:26     ` Stephen Boyd
2009-11-14  4:34 ` [PATCH 2/2] ls-tree: migrate to parse-options Stephen Boyd
2009-11-17  6:22   ` Junio C Hamano
2009-11-17  6:28     ` Stephen Boyd
2009-11-17  7:02     ` Stephen Boyd
2009-11-18 22:19       ` Junio C Hamano
2009-11-18 23:10         ` Thiago Farina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4c8a6d00911181510y66338536wb4b51b0df4788e76@mail.gmail.com \
    --to=tfransosi@gmail.com \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).