From: Jeff Hostetler <git@jeffhostetler.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>, git@vger.kernel.org
Cc: jeffhost@microsoft.com
Subject: Re: [RFC PATCH] fsmonitor: fix building with NO_PTHREADS
Date: Tue, 17 Aug 2021 13:56:10 -0400 [thread overview]
Message-ID: <a5468146-aa26-62a1-2c7e-e35fa73ff041@jeffhostetler.com> (raw)
In-Reply-To: <20210817082310.2157-1-carenas@gmail.com>
On 8/17/21 4:23 AM, Carlo Marcelo Arenas Belón wrote:
> something similar will be needed for the NO_UNIX_SOCKETS, since the
> system setting for support of FSMONITOR_DAEMON_BACKEND is not enough
> to cover for the code dependencies.
>
> alternatively FSMONITOR_DAEMON_BACKEND could be used to imply support
> was requested AND code dependencies are covered, but this setup at
> least allows for building and uses the "mock" implementation.
>
> since the enum is needed for the fallback code, had to be moved outside
> of the #ifdef
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ...
Thanks, I'll incorporate this into my next version.
BTW, what platform did you detect this on?
Jeff
next prev parent reply other threads:[~2021-08-17 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 8:23 [RFC PATCH] fsmonitor: fix building with NO_PTHREADS Carlo Marcelo Arenas Belón
2021-08-17 17:56 ` Jeff Hostetler [this message]
2021-08-18 9:44 ` Carlo Arenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5468146-aa26-62a1-2c7e-e35fa73ff041@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).