From: Pat Thoyts <patthoyts@googlemail.com>
To: Kirill <kirillathome@gmail.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [msysGit] [PATCH] Provide a window icon on Windows platforms
Date: Thu, 31 Dec 2009 21:12:18 +0000 [thread overview]
Message-ID: <a5b261830912311312if3d71aax5bb693a907dc5c0f@mail.gmail.com> (raw)
In-Reply-To: <1262289470-4208-1-git-send-email-kirillathome@gmail.com>
2009/12/31 Kirill <kirillathome@gmail.com>:
> Looks like 37871b73 by Giuseppe Bilotta does not work very well on Windows.
> Instead of a former tcl/tk icon, the window has a black square as an icon.
I've been using versions of gitk on Windows with that patch since it
was applied in March and it has been fine. On Windows XP and Windows
7. So there is more to this than you are telling. Are you using
windows via remote desktop? There was a patch committed to Tk a while
ago about the program icon displaying as a black square over remote
desktop. If so, this requires an updated Tk and not a patch to gitk -
tk 8.5.8 should be ok if this is the problem.
next prev parent reply other threads:[~2009-12-31 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 19:57 [PATCH] Provide a window icon on Windows platforms Kirill
2009-12-31 20:02 ` Jeff Epler
2009-12-31 20:13 ` Kirill
2009-12-31 21:12 ` Pat Thoyts [this message]
2009-12-31 22:42 ` Kirill
2009-12-31 23:47 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5b261830912311312if3d71aax5bb693a907dc5c0f@mail.gmail.com \
--to=patthoyts@googlemail.com \
--cc=git@vger.kernel.org \
--cc=kirillathome@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).