From: Josh Micich <josh.micich@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Josh Micich <josh.micich@gmail.com>
Subject: Re: [PATCH 1/3] '--missing' option for mktree: re-added strbuf_release(&p_uq), Updated man page
Date: Thu, 14 May 2009 12:44:10 -0700 [thread overview]
Message-ID: <a644352c0905141244v4c8bdef6t69318152dc02c6a@mail.gmail.com> (raw)
In-Reply-To: <7vprecxlrw.fsf@alter.siamese.dyndns.org>
On Wed, May 13, 2009 at 11:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> path = strbuf_detach(&p_uq, NULL);
>> + append_to_tree(mode, sha1, path);
>> + strbuf_release(&p_uq);
>> + return;
>> }
>> append_to_tree(mode, sha1, path);
>> }
>
> Ehh, why? detach already detaches the allocated buffer from strbuf and
> there is nothing to clean up by strbuf_release().
>
My bad. While re-basing my work to fe0bb5, the strbuf_release() call
went missing, but I didn't notice you had also changed:
- path = p_uq.buf;
+ path = strbuf_detach(&p_uq, NULL);
That is much nicer
next prev parent reply other threads:[~2009-05-14 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 5:06 Proposed patch for mktree [0/3] Josh Micich
2009-05-14 5:09 ` [PATCH 1/3] '--missing' option for mktree: re-added strbuf_release(&p_uq), Updated man page Josh Micich
2009-05-14 6:04 ` Junio C Hamano
2009-05-14 19:44 ` Josh Micich [this message]
2009-05-14 5:10 ` [PATCH 2/3] added --batch option to mktree Josh Micich
2009-05-14 6:18 ` Junio C Hamano
2009-05-14 9:24 ` Josh Micich
2009-05-14 10:25 ` Sverre Rabbelier
2009-05-14 19:51 ` Josh Micich
[not found] ` <a644352c0905140217h382a4d18h988b229c12577de3@mail.gmail.com>
2009-05-15 8:31 ` Junio C Hamano
2009-05-14 5:11 ` [PATCH 3/3] improved validation of entry type in mktree Josh Micich
2009-05-14 6:24 ` Junio C Hamano
2009-05-14 22:46 ` Josh Micich
2009-05-14 22:49 ` Josh Micich
2009-05-15 6:23 ` Jakub Narebski
2009-05-15 16:57 ` Josh Micich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a644352c0905141244v4c8bdef6t69318152dc02c6a@mail.gmail.com \
--to=josh.micich@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).