From: "René Scharfe" <l.s.r@web.de>
To: Simon Ruderich <simon@ruderich.org>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
Yaroslav Halchenko <yoh@onerussian.com>
Subject: Re: [PATCH] strbuf: clear errno before calling getdelim(3)
Date: Sat, 12 Aug 2017 14:21:12 +0200 [thread overview]
Message-ID: <a6fe4020-4e3d-0561-db70-2eb87e0680c7@web.de> (raw)
In-Reply-To: <510f566b-3aee-98fd-9663-d97c3dcfeb96@web.de>
Am 12.08.2017 um 13:57 schrieb René Scharfe:
> Update: Just noticed that on the BSDs getdelim(3) doesn't set errno
> to ENOMEM on allocation failure, but does set the error indicator.
> That might be an oversight on their part, but that means we
> certainly *need* to check ferror(). And an unchanged errno can
> mean ENOMEM there. Ugh..
I take that back. The memory allocation function called by getdelim
will of course set errno on failure. I got fooled by the manpages,
which don't mention ENOMEM, e.g.: https://man.openbsd.org/getdelim.
René
next prev parent reply other threads:[~2017-08-12 12:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 17:39 fatal: Out of memory, getdelim failed under NFS mounts Yaroslav Halchenko
2017-08-10 13:27 ` René Scharfe
2017-08-10 14:43 ` Yaroslav Halchenko
2017-08-10 19:44 ` René Scharfe
2017-08-10 18:56 ` Junio C Hamano
2017-08-10 19:44 ` Yaroslav Halchenko
2017-08-10 19:58 ` René Scharfe
2017-08-10 20:05 ` Jeff King
2017-08-10 20:29 ` Yaroslav Halchenko
2017-08-10 20:56 ` [PATCH] strbuf: clear errno before calling getdelim(3) René Scharfe
2017-08-10 21:02 ` Jeff King
2017-08-10 21:35 ` Yaroslav Halchenko
2017-08-10 21:41 ` Junio C Hamano
2017-08-11 7:50 ` Simon Ruderich
2017-08-11 8:52 ` René Scharfe
2017-08-12 10:02 ` Simon Ruderich
2017-08-12 11:57 ` René Scharfe
2017-08-12 12:21 ` René Scharfe [this message]
2017-08-13 4:32 ` Jeff King
2017-08-13 5:51 ` René Scharfe
2017-08-13 5:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6fe4020-4e3d-0561-db70-2eb87e0680c7@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=simon@ruderich.org \
--cc=yoh@onerussian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).