From: Caleb Thompson <caleb@calebthompson.io>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Jeremiah Mahler <jmmahler@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v6 1/4] commit test: Use test_config instead of git-config
Date: Tue, 17 Jun 2014 14:38:57 -0500 [thread overview]
Message-ID: <a7aa2efcb6a2beba973c389f5c7afbce79ec9747.1403033723.git.caleb@calebthompson.io> (raw)
In-Reply-To: <cover.1403033723.git.caleb@calebthompson.io>
In-Reply-To: <cover.1403033723.git.caleb@calebthompson.io>
Some of the tests in t/t7507-commit-verbose.sh were still using
git-config to set configuration. Change them to use the test_config
helper.
Signed-off-by: Caleb Thompson <caleb@calebthompson.io>
Reviewed-by: Jeremiah Mahler <jmmahler@gmail.com>
---
t/t7507-commit-verbose.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
index 2ddf28c..6d778ed 100755
--- a/t/t7507-commit-verbose.sh
+++ b/t/t7507-commit-verbose.sh
@@ -43,7 +43,7 @@ test_expect_success 'verbose diff is stripped out' '
'
test_expect_success 'verbose diff is stripped out (mnemonicprefix)' '
- git config diff.mnemonicprefix true &&
+ test_config diff.mnemonicprefix true &&
git commit --amend -v &&
check_message message
'
@@ -71,7 +71,7 @@ test_expect_success 'diff in message is retained with -v' '
'
test_expect_success 'submodule log is stripped out too with -v' '
- git config diff.submodule log &&
+ test_config diff.submodule log &&
git submodule add ./. sub &&
git commit -m "sub added" &&
(
--
2.0.0
next prev parent reply other threads:[~2014-06-17 19:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 19:38 [PATCH v6 0/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-17 19:38 ` Caleb Thompson [this message]
2014-06-17 21:31 ` [PATCH v6 1/4] commit test: Use test_config instead of git-config Junio C Hamano
2014-06-17 21:35 ` Junio C Hamano
2014-06-17 19:38 ` [PATCH v6 2/4] commit test: Use write_script Caleb Thompson
2014-06-17 19:38 ` [PATCH v6 3/4] commit test: test_set_editor in each test Caleb Thompson
2014-06-17 19:39 ` [PATCH v6 4/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-17 21:21 ` Jeff King
2014-06-17 21:37 ` Junio C Hamano
2014-06-17 21:39 ` Jeff King
2015-02-27 9:13 ` [PATCH v6 0/4] " Torstein Hegge
2015-03-02 19:02 ` Caleb Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7aa2efcb6a2beba973c389f5c7afbce79ec9747.1403033723.git.caleb@calebthompson.io \
--to=caleb@calebthompson.io \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jmmahler@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).