git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Devin Doucette" <devin@doucette.cc>
To: git@vger.kernel.org
Cc: "Petr Baudis" <petr.baudis@novartis.com>,
	"Jakub Narebski" <jnareb@gmail.com>
Subject: [PATCH] gitweb: Fix export check in git_get_projects_list
Date: Sat, 27 Dec 2008 02:39:31 -0700	[thread overview]
Message-ID: <a899d7ef0812270139u7dd28ee1q45a8c05f7c95db2f@mail.gmail.com> (raw)

When $filter was empty, the path passed to check_export_ok would
contain an extra '/', which some implementations of export_auth_hook
are sensitive to.

It makes more sense to fix this here than to handle the special case
in each implementation of export_auth_hook.

Signed-off-by: Devin Doucette <devin@doucette.cc>
---
 gitweb/gitweb.perl |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 8f574c7..99f71b4 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2147,8 +2147,9 @@ sub git_get_projects_list {

 				my $subdir = substr($File::Find::name, $pfxlen + 1);
 				# we check related file in $projectroot
-				if (check_export_ok("$projectroot/$filter/$subdir")) {
-					push @list, { path => ($filter ? "$filter/" : '') . $subdir };
+				my $path = ($filter ? "$filter/" : '') . $subdir;
+				if (check_export_ok("$projectroot/$path")) {
+					push @list, { path => $path };
 					$File::Find::prune = 1;
 				}
 			},
-- 
1.6.1.rc4

             reply	other threads:[~2008-12-27  9:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-27  9:39 Devin Doucette [this message]
2008-12-28  2:12 ` [PATCH] gitweb: Fix export check in git_get_projects_list Jakub Narebski
2008-12-28  6:54   ` Junio C Hamano
2008-12-29 12:29   ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a899d7ef0812270139u7dd28ee1q45a8c05f7c95db2f@mail.gmail.com \
    --to=devin@doucette.cc \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=petr.baudis@novartis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).