From: Patrick Steinhardt <ps@pks.im>
To: Eli Schwartz <eschwartz@gentoo.org>
Cc: git@vger.kernel.org, Sam James <sam@gentoo.org>
Subject: Re: [PATCH 3/6] meson: do a full usage-based compile check for sysinfo
Date: Tue, 22 Apr 2025 09:31:32 +0200 [thread overview]
Message-ID: <aAdF1MvGJcqfpI4p@pks.im> (raw)
In-Reply-To: <20250421175247.240971-3-eschwartz@gentoo.org>
On Mon, Apr 21, 2025 at 01:51:47PM -0400, Eli Schwartz wrote:
> diff --git a/meson.build b/meson.build
> index f5d9ffcd7f..8037e536dd 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1058,10 +1058,6 @@ if compiler.has_header('alloca.h')
> libgit_c_args += '-DHAVE_ALLOCA_H'
> endif
>
> -if compiler.has_header('sys/sysinfo.h')
> - libgit_c_args += '-DHAVE_SYSINFO'
> -endif
> -
> # Windows has libgen.h and a basename implementation, but we still need our own
> # implementation to threat things like drive prefixes specially.
> if host_machine.system() == 'windows' or not compiler.has_header('libgen.h')
> @@ -1272,6 +1268,10 @@ if host_machine.system() != 'windows'
> endif
> endif
>
> +if compiler.has_member('struct sysinfo', 'totalram', prefix: '#include <sys/sysinfo.h>')
> + libgit_c_args += '-DHAVE_SYSINFO'
> +endif
Makes sense. We do have c9a51775a36 (builtin/gc.c: correct RAM
calculation when using sysinfo, 2025-04-17) in flight which also causes
us to use `struct sysinfo::mem_unit`. But I think it's fine to check for
only one of the members here.
Patrick
next prev parent reply other threads:[~2025-04-22 7:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 17:51 [PATCH 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-21 17:51 ` [PATCH 2/6] meson: check for getpagesize before using it Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-24 23:48 ` Junio C Hamano
2025-04-25 0:06 ` Eli Schwartz
2025-04-21 17:51 ` [PATCH 3/6] meson: do a full usage-based compile check for sysinfo Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt [this message]
2025-04-21 17:51 ` [PATCH 4/6] meson: add a couple missing networking dependencies Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-21 17:51 ` [PATCH 5/6] meson: fix typo in function check that prevented checking for hstrerror Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-21 17:51 ` [PATCH 6/6] meson: only check for missing networking syms on non-Windows; add compat impls Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-22 15:27 ` Eli Schwartz
2025-04-23 11:25 ` Patrick Steinhardt
2025-04-21 20:04 ` [PATCH 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-22 0:33 ` Junio C Hamano
2025-04-22 0:58 ` Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-22 15:36 ` Eli Schwartz
2025-04-23 11:25 ` Patrick Steinhardt
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-22 15:17 ` Junio C Hamano
2025-04-25 0:13 ` [PATCH v2 0/6] meson: miscellaneous system detection fixes Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 2/6] meson: check for getpagesize before using it Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 3/6] meson: do a full usage-based compile check for sysinfo Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 4/6] meson: add a couple missing networking dependencies Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 5/6] meson: fix typo in function check that prevented checking for hstrerror Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 6/6] meson: only check for missing networking syms on non-Windows; add compat impls Eli Schwartz
2025-04-25 4:39 ` [PATCH v2 0/6] meson: miscellaneous system detection fixes Patrick Steinhardt
2025-04-25 5:27 ` Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 " Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 2/6] meson: check for getpagesize before using it Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 3/6] meson: do a full usage-based compile check for sysinfo Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 4/6] meson: add a couple missing networking dependencies Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 5/6] meson: fix typo in function check that prevented checking for hstrerror Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 6/6] meson: only check for missing networking syms on non-Windows; add compat impls Eli Schwartz
2025-04-25 9:53 ` [PATCH v3 0/6] meson: miscellaneous system detection fixes Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAdF1MvGJcqfpI4p@pks.im \
--to=ps@pks.im \
--cc=eschwartz@gentoo.org \
--cc=git@vger.kernel.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).