From: Patrick Steinhardt <ps@pks.im>
To: Lidong Yan via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Lidong Yan <502024330056@smail.nju.edu.cn>
Subject: Re: [PATCH v2] fill_oids_from_packs: fix memory leak when fill_oids_from_packs failed
Date: Fri, 9 May 2025 10:25:15 +0200 [thread overview]
Message-ID: <aB2765DnIjb1xDQW@pks.im> (raw)
In-Reply-To: <pull.1957.v2.git.git.1746774869081.gitgitgadget@gmail.com>
On Fri, May 09, 2025 at 07:14:28AM +0000, Lidong Yan via GitGitGadget wrote:
> From: Lidong Yan <502024330056@smail.nju.edu.cn>
>
> In commit-graph.c:fill_oids_from_packs, if open_pack_index failed,
> memory allocated and returned by add_packed_git will leak. Simply
> add close_pack and free(p) will solve this problem.
One more thing that I missed in the first review: the commit subject
should mention the subsystem as prefix, not the specific function. So It
should e.g. read:
commit-grap: fix memory leak when `fill_oids_from_packs()` fails
Patrick
next prev parent reply other threads:[~2025-05-09 8:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 13:51 [PATCH] fill_oids_from_packs: fix memory leak when fill_oids_from_packs failed Lidong Yan via GitGitGadget
2025-05-09 5:38 ` Patrick Steinhardt
2025-05-09 7:06 ` lidongyan
2025-05-09 7:14 ` [PATCH v2] " Lidong Yan via GitGitGadget
2025-05-09 8:25 ` Patrick Steinhardt [this message]
2025-05-09 8:30 ` [PATCH v3] commit-grap: fix memory leak when `fill_oids_from_packs()` fails Lidong Yan via GitGitGadget
2025-05-15 21:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aB2765DnIjb1xDQW@pks.im \
--to=ps@pks.im \
--cc=502024330056@smail.nju.edu.cn \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).