From: Patrick Steinhardt <ps@pks.im>
To: Lidong Yan via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>,
"Lidong Yan" <502024330056@smail.nju.edu.cn>
Subject: Re: [PATCH v3] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro
Date: Fri, 9 May 2025 10:23:47 +0200 [thread overview]
Message-ID: <aB27k8DI3BNgiwS-@pks.im> (raw)
In-Reply-To: <pull.1955.v3.git.git.1746776686718.gitgitgadget@gmail.com>
On Fri, May 09, 2025 at 07:44:46AM +0000, Lidong Yan via GitGitGadget wrote:
> From: Lidong Yan <502024330056@smail.nju.edu.cn>
>
> REFTABLE_REALLOC_ARRAY will cause memory leak if realloc failed.
> Since it is unused, remove this unsafe macro.
This looks good to me, thanks!
Patrick
next prev parent reply other threads:[~2025-05-09 8:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 13:39 [PATCH] REFTABLE_REALLOC_ARRAY: fix potential memory leak if realloc failed Lidong Yan via GitGitGadget
2025-05-08 21:42 ` René Scharfe
2025-05-09 1:54 ` lidongyan
2025-05-09 3:43 ` Junio C Hamano
2025-05-09 2:04 ` [PATCH v2] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro Lidong Yan via GitGitGadget
2025-05-09 6:51 ` Patrick Steinhardt
2025-05-09 7:38 ` lidongyan
2025-05-09 7:44 ` [PATCH v3] " Lidong Yan via GitGitGadget
2025-05-09 8:23 ` Patrick Steinhardt [this message]
2025-05-09 14:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aB27k8DI3BNgiwS-@pks.im \
--to=ps@pks.im \
--cc=502024330056@smail.nju.edu.cn \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).