From: Patrick Steinhardt <ps@pks.im>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>,
Ayush Chandekar <ayu.chandekar@gmail.com>
Subject: Re: [PATCH] replay: replace the_repository with repo parameter passed to cmd_replay()
Date: Thu, 15 May 2025 15:24:13 +0200 [thread overview]
Message-ID: <aCXq_ck96l0AjScp@pks.im> (raw)
In-Reply-To: <pull.1921.git.1747254806067.gitgitgadget@gmail.com>
On Wed, May 14, 2025 at 08:33:25PM +0000, Elijah Newren via GitGitGadget wrote:
> From: Elijah Newren <newren@gmail.com>
>
> Replace the_repository everywhere with repo, feed repo from cmd_replay()
> to all the other functions in the file that need it, and remove the
> UNUSED annotation on repo.
>
> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
> replay: replace the_repository with repo parameter passed to cmd_replay
>
> The point of this patch is not to remove USE_THE_REPOSITORY_VARIABLE; I
> can't yet because DEFAULT_ABBREV and get_commit_output_encoding() both
> require it and have no current alternatives. However, I still think it's
> worthwhile to stop using the_repository everywhere while ignoring the
> repo parameter explicitly passed in. That looks kinda ugly, and since
> I'm poking around in replay right now, I don't want to push
> the_repository in even more places when we have the appropriate value
> available -- especially since that might make my local work conflict
> should someone else come along and try to clean this up.
Makes sense. Especially the first one is something I have encountered as
a frequent blocker for removing `USE_THE_REPOSITORY_VARIABLE`. I guess
it would be nice to tackle it sooner rather than later.
Cc'd Ayush, as he will be working on the global state reduction project
as part of GSoC.
Patrick
prev parent reply other threads:[~2025-05-15 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 20:33 [PATCH] replay: replace the_repository with repo parameter passed to cmd_replay() Elijah Newren via GitGitGadget
2025-05-14 22:10 ` Junio C Hamano
2025-05-15 13:24 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCXq_ck96l0AjScp@pks.im \
--to=ps@pks.im \
--cc=ayu.chandekar@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).