From: Chris Down <chris@chrisdown.name>
To: Junio C Hamano <gitster@pobox.com>
Cc: "D. Ben Knoble" <ben.knoble@gmail.com>,
git@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] commit: Add commit.signoff configuration option
Date: Fri, 16 May 2025 16:04:25 +0100 [thread overview]
Message-ID: <aCdT-UQtaaTQ8gyD@chrisdown.name> (raw)
In-Reply-To: <xmqqldqwya5p.fsf@gitster.g>
Junio C Hamano writes:
>Regarding other problems, the fact that we are having this
>discussion is indication enough, isn't it? If it didn't exist, we
>wouldn't have had folks who used it as an excuse to promote
>commit.signoff in the first place.
I definitely understand your concern about diluting the meaning of signoffs.
What separates this patch is that it's not suggesting a config option out of
feature parity, but because enabling commit.signoff is itself a deliberate,
repository specific certification, which is arguably more meaningful than
habitually typing -s for each commit or using a global shell alias.
The repository specificity is particularly important here. Currently users work
around this with shell aliases, which are global rather than scoped to a
repository, making commit.signoff in practice a more precise mechanism for
expressing their intent about what to certify.
Would strengthening the documentation to emphasise that setting commit.signoff
is a deliberate, repository-specific certification address your concern about
diluting the meaning of signoffs?
next prev parent reply other threads:[~2025-05-16 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 12:20 [PATCH] commit: Add commit.signoff configuration option Chris Down
2025-05-13 13:12 ` Kristoffer Haugsbakk
2025-05-13 21:09 ` D. Ben Knoble
2025-05-14 16:46 ` Chris Down
2025-05-15 0:17 ` Junio C Hamano
2025-05-15 13:22 ` Chris Down
2025-05-16 13:09 ` Junio C Hamano
2025-05-16 15:04 ` Chris Down [this message]
2025-06-03 6:54 ` Chris Down
2025-06-04 13:32 ` Junio C Hamano
2025-06-05 1:46 ` Collin Funk
2025-06-09 4:24 ` Chris Down
2025-05-16 11:50 ` Ben Knoble
2025-05-16 14:28 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCdT-UQtaaTQ8gyD@chrisdown.name \
--to=chris@chrisdown.name \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).