From: Patrick Steinhardt <ps@pks.im>
To: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Cc: git@vger.kernel.org, karthik.188@gmail.com
Subject: Re: [GSoC PATCH v2 0/2] MyFirstObjectWalk: update with struct repository and meson
Date: Tue, 3 Jun 2025 08:08:35 +0200 [thread overview]
Message-ID: <aD6RY99Me3bPoB--@pks.im> (raw)
In-Reply-To: <20250602205021.4223-1-lucasseikioshiro@gmail.com>
On Mon, Jun 02, 2025 at 05:50:19PM -0300, Lucas Seiki Oshiro wrote:
> Hi!
>
> This v2:
>
> - Applies the suggestions from Karthik to the commit messages and the
> documentation content;
>
> - Makes it more clear where to place the new Meson, as pointed by Patrick.
>
> Thanks!
It would be great if you could include the range-diff for future patch
series. You can either generate it via git-format-patch(1), or use a
tool like b4 that automates a lot of this for you. This would help
reviewers to see what exactly has changed.
In any case, this version looks good to me. Thanks!
Patrick
prev parent reply other threads:[~2025-06-03 6:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 19:20 [GSoC PATCH 0/2] Update MyFirstObjectWalk with struct repository and meson Lucas Seiki Oshiro
2025-05-29 19:20 ` [GSoC PATCH 1/2] MyFirstContribution: use struct repository in examples Lucas Seiki Oshiro
2025-05-29 19:57 ` Karthik Nayak
2025-05-29 19:20 ` [GSoC PATCH 2/2] MyFirstContribution: add walken.c to meson.build Lucas Seiki Oshiro
2025-05-29 20:02 ` Karthik Nayak
2025-05-30 8:00 ` Patrick Steinhardt
2025-05-29 20:06 ` [GSoC PATCH 0/2] Update MyFirstObjectWalk with struct repository and meson Karthik Nayak
2025-06-02 20:50 ` [GSoC PATCH v2 0/2] MyFirstObjectWalk: update " Lucas Seiki Oshiro
2025-06-02 20:50 ` [GSoC PATCH v2 1/2] MyFirstContribution: use struct repository in examples Lucas Seiki Oshiro
2025-06-02 20:50 ` [GSoC PATCH v2 2/2] MyFirstContribution: add walken.c to meson.build Lucas Seiki Oshiro
2025-06-03 6:08 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aD6RY99Me3bPoB--@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=lucasseikioshiro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).