git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Down <chris@chrisdown.name>
To: Junio C Hamano <gitster@pobox.com>
Cc: "D. Ben Knoble" <ben.knoble@gmail.com>,
	git@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] commit: Add commit.signoff configuration option
Date: Mon, 2 Jun 2025 23:54:31 -0700	[thread overview]
Message-ID: <aD6cJxFXdGfN2XGc@chrisdown.name> (raw)
In-Reply-To: <aCdT-UQtaaTQ8gyD@chrisdown.name>

Hi Junio,

I wanted to follow up on the point around repository specificity, since that 
seems pretty key to the discussion here.

Looking at public dotfiles, many users already work around this with global 
shell aliases for "commit --signoff". This creates the exact problem (I 
believe?) you're concerned about: casual, low intent signoffs without 
deliberate per-repository intent to certify anything.

A repository specific commit.signoff would be more precise than the current 
workarounds, since it would require explicit configuration per repository 
rather than blanket global behavior or muscle memory.

Would only allowing using this flag in a repository context (and not the global 
git config) allay your concerns?

Thanks,

Chris

  reply	other threads:[~2025-06-03  6:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 12:20 [PATCH] commit: Add commit.signoff configuration option Chris Down
2025-05-13 13:12 ` Kristoffer Haugsbakk
2025-05-13 21:09 ` D. Ben Knoble
2025-05-14 16:46   ` Chris Down
2025-05-15  0:17     ` Junio C Hamano
2025-05-15 13:22       ` Chris Down
2025-05-16 13:09         ` Junio C Hamano
2025-05-16 15:04           ` Chris Down
2025-06-03  6:54             ` Chris Down [this message]
2025-06-04 13:32               ` Junio C Hamano
2025-06-05  1:46                 ` Collin Funk
2025-06-09  4:24                 ` Chris Down
2025-05-16 11:50     ` Ben Knoble
2025-05-16 14:28       ` Chris Down

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aD6cJxFXdGfN2XGc@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kernel-team@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).