From: Patrick Steinhardt <ps@pks.im>
To: oneee via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, oneee <kimww0306@gmail.com>
Subject: Re: [PATCH] doc: sparse-checkout: Fix list markers
Date: Wed, 28 May 2025 09:14:24 +0200 [thread overview]
Message-ID: <aDa30OJmvcfp1_mM@pks.im> (raw)
In-Reply-To: <pull.1948.git.git.1745239300668.gitgitgadget@gmail.com>
On Mon, Apr 21, 2025 at 12:41:40PM +0000, oneee via GitGitGadget wrote:
> From: onee-only <kimww0306@gmail.com>
>
> Changed the list markers from a mix of "(1)" and "(b)" to a
> consistent numeric format "(1)", "(2)" for clarity and consistency.
In Git we use imperative style for commit messages, as if requesting the
code to change. So something like this for example:
We use a mix of "(1)" and "(b)" to refer to different cases when
explaining sparsity patterns. Adapt these markers to use the numeric
format for both clarity and consistency.
> Signed-off-by: onee-only <kimww0306@gmail.com>
We typically prefer your full name instead of using nicknames here. So
if you want to provide your full name, please do so.
> diff --git a/Documentation/technical/sparse-checkout.adoc b/Documentation/technical/sparse-checkout.adoc
> index dc2e763bbec..8202172b70b 100644
> --- a/Documentation/technical/sparse-checkout.adoc
> +++ b/Documentation/technical/sparse-checkout.adoc
> @@ -66,7 +66,7 @@ sparsity patterns: patterns from $GIT_DIR/info/sparse-checkout used to
> reasons: (1) users in cone mode specify directories rather than
> patterns (their directories are transformed into patterns, but
> users may think you are talking about non-cone mode if you use the
> - word "patterns"), and (b) the sparse specification might
> + word "patterns"), and (2) the sparse specification might
> transiently differ in the working tree or index from the sparsity
> patterns (see "Sparse specification vs. sparsity patterns").
The change itself looks like an obvious improvement to me, thanks!
Patrick
next prev parent reply other threads:[~2025-05-28 7:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 12:41 [PATCH] doc: sparse-checkout: Fix list markers oneee via GitGitGadget
2025-05-28 6:56 ` Kristoffer Haugsbakk
2025-05-28 7:20 ` Eric Sunshine
2025-05-28 8:01 ` Kristoffer Haugsbakk
2025-05-30 3:43 ` oneee
2025-05-30 5:00 ` Eric Sunshine
2025-05-30 7:18 ` oneee
2025-05-30 13:38 ` Junio C Hamano
2025-05-28 7:14 ` Patrick Steinhardt [this message]
2025-05-30 7:22 ` [PATCH v2] doc: sparse-checkout: use consistent inline list style oneee via GitGitGadget
2025-05-30 7:41 ` Kristoffer Haugsbakk
-- strict thread matches above, loose matches on Subject: below --
2025-05-28 6:19 [PATCH] doc: sparse-checkout: Fix list markers oneee
2025-05-28 6:36 ` Kristoffer Haugsbakk
2025-05-28 7:14 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDa30OJmvcfp1_mM@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kimww0306@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).