From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] silencing warnings with curl 8.14
Date: Thu, 5 Jun 2025 07:21:37 +0200 [thread overview]
Message-ID: <aEEpYQsE36skWxk5@pks.im> (raw)
In-Reply-To: <20250604205505.GA1510724@coredump.intra.peff.net>
On Wed, Jun 04, 2025 at 04:55:05PM -0400, Jeff King wrote:
> The new version of curl (which hit Debian unstable a few days ago)
> causes a bunch of compiler warnings because we are passing regular ints
> to curl_easy_setopt() instead of longs. Passing longs has always been
> what you're supposed to do, but the new version is better about
> generating warnings with gcc (I think the type-check has been there for
> a long time, but I gather it was broken and recently fixed).
>
> I split this into three patches since the solutions vary slightly (well,
> the last two are the same, but my pontificating on the solution varies).
All of these look good to me, thanks!
Patrick
prev parent reply other threads:[~2025-06-05 5:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 20:55 [PATCH 0/3] silencing warnings with curl 8.14 Jeff King
2025-06-04 20:55 ` [PATCH 1/3] curl: fix integer constant typechecks with curl_easy_setopt() Jeff King
2025-06-05 10:57 ` Johannes Schindelin
2025-06-05 16:04 ` Junio C Hamano
2025-06-05 22:49 ` Jeff King
2025-06-05 22:51 ` Jeff King
2025-06-05 23:13 ` Junio C Hamano
2025-06-05 22:47 ` Jeff King
2025-06-04 20:55 ` [PATCH 2/3] curl: fix integer variable " Jeff King
2025-06-04 20:56 ` [PATCH 3/3] curl: fix symbolic constant " Jeff King
2025-06-04 21:25 ` Junio C Hamano
2025-06-05 6:13 ` Daniel Stenberg
2025-06-05 7:25 ` Jeff King
2025-06-04 21:23 ` [PATCH 0/3] silencing warnings with curl 8.14 Collin Funk
2025-06-04 22:03 ` Ramsay Jones
2025-06-05 5:21 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEEpYQsE36skWxk5@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).