Re: [PATCH 6/6] parse-options: add precision handling for OPTION_COUNTUP

[Patrick Steinhardt <ps@pks.im>]

On Tue, Jul 01, 2025 at 06:01:44PM +0200, René Scharfe wrote:
> On 7/1/25 12:55 PM, Patrick Steinhardt wrote:
> > On Sun, Jun 29, 2025 at 01:51:36PM +0200, René Scharfe wrote:
> >> diff --git a/parse-options.c b/parse-options.c
> >> index 0dc9b0324a..0dd08a3a77 100644
> >> --- a/parse-options.c
> >> +++ b/parse-options.c
> >> diff --git a/parse-options.h b/parse-options.h
> >> index 8bdf469ae9..312045604d 100644
> >> --- a/parse-options.h
> >> +++ b/parse-options.h
> >> @@ -183,6 +183,7 @@ struct option {
> >>  	.short_name = (s), \
> >>  	.long_name = (l), \
> >>  	.value = (v), \
> > 
> > It's a bit surprising that `COUNTUP` accepts a signed integer, so should
> > we maybe add `BARF_UNLESS_SIGNED(*(v))` here?
> 
> Perhaps, but that would require more changes to callers that use unsigned
> variables than I can stomach.  That's why I declared it out of scope for
> this series in its cover letter.  Later, unless (hopefully) someone beats
> me to it.

Fine with me, thanks!

Patrick