From: Patrick Steinhardt <ps@pks.im>
To: Han Young <hanyang.tony@bytedance.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] blame: only parse detailed commit info if needed
Date: Tue, 22 Jul 2025 16:15:54 +0200 [thread overview]
Message-ID: <aH-dGhHm2xuY4yT3@pks.im> (raw)
In-Reply-To: <20250722114220.87570-1-hanyang.tony@bytedance.com>
On Tue, Jul 22, 2025 at 07:42:20PM +0800, Han Young wrote:
> In commit cee7f245d (git-pickaxe: blame rewritten., 2006-10-19),
> The function get_commit_info can terminate commit parsing early if only
> the author information is needed. This ability is not used by callers
> who do not require detailed commit information. Stop requesting detailed
> commit information for these callers.
Okay. I think there's two important pieces of information missing here:
- What does this buy us? I guess the answer is performance, but it
would be sure to quantify in which scenarios and how much of a
speedup this buys us.
- Any reasoning why those two callers don't need the information.
Reviewers can try to piece it together manually, but it would be
nice to hold their hand and lead them through the change.
Thanks!
Patrick
next prev parent reply other threads:[~2025-07-22 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 11:42 [PATCH] blame: only parse detailed commit info if needed Han Young
2025-07-22 14:15 ` Patrick Steinhardt [this message]
2025-07-22 17:08 ` Junio C Hamano
2025-07-23 6:02 ` [External] " Han Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aH-dGhHm2xuY4yT3@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanyang.tony@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).