From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from complex.crustytoothpaste.net (complex.crustytoothpaste.net [172.105.7.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F54A13B58A for ; Thu, 17 Jul 2025 21:30:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.105.7.114 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752787848; cv=none; b=cfJw/9LbwDNmY0SDJ7JaOpFTfTbGcAIiyyoqyiXti92fMRI85kRmlXve55qnTf0Rgi8blMEnj4ZproGq2vo+J4vWU/NX4nP4Sm4KkRZAriRjfsG9W0G09l+ArL+W6tddqQ4LstJ3wafr2gAXtRqclrQKz+fge1dbAurJ91lTHFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752787848; c=relaxed/simple; bh=tEsqZwAGYxImtefohl0hVYhD411t2Au27yDdTWE2n38=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C/J0eeeXRUrdJgE+MwvDWSo9Tbr6rqoTM36NgfNGLh0YX64L8CLZFSkOoK/0VinRJBCJyuAjGHwNWd3iUb0ZgjlWd1a9wq0o4OfRT2wgHCzxhXJCttDmZGDB6JZY9pZg0dLZlt9AMD+sf3IHYK0Dwjj/8oNqyAI1tLMVZmBYzlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=crustytoothpaste.net; spf=pass smtp.mailfrom=crustytoothpaste.net; dkim=pass (3072-bit key) header.d=crustytoothpaste.net header.i=@crustytoothpaste.net header.b=yYFw/T5D; arc=none smtp.client-ip=172.105.7.114 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=crustytoothpaste.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=crustytoothpaste.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (3072-bit key) header.d=crustytoothpaste.net header.i=@crustytoothpaste.net header.b="yYFw/T5D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=crustytoothpaste.net; s=default; t=1752787844; bh=tEsqZwAGYxImtefohl0hVYhD411t2Au27yDdTWE2n38=; h=Date:From:To:Cc:Subject:References:Content-Type: Content-Disposition:In-Reply-To:From:Reply-To:Subject:Date:To:CC: Resent-Date:Resent-From:Resent-To:Resent-Cc:In-Reply-To:References: Content-Type:Content-Disposition; b=yYFw/T5DLTnsXbmWcNhVlkVYvm3WjzIcbUMPDxI8wDHQuU7yOBjYZ0XVdvXaY94r1 C2zYMDh4B+671ljubONaLg+2rdggVIkiiCnRn43RsivRNN9HHqkeKwSjIERII+ro7I SsnmXitrVDgDPiQEblCZ6voZvZkAWt72v8/m7YGFYFKzWDffpFL/bsuS14+dQ/8qlr Rg54/y+7froFIpsUATesI7tBm7K7l2Wx1LIUKxA5CcmBq8Xcn0XhGvBqyAnUrpLAhs gfKyr62i47NQWBmfe7TkvWg0z/KCus1SXqd0bemzIGdEaFv7FjbCUI8d1lBAPn5+sO lA7T+8fL18EoFEcOGy9+qzvpvMluaJAyCMedDVO1Zx175sNkAXRQho6YrrHAPVB8J7 5l3aqjzhN9WM6GLkJmns97HwHm00+p3teRWCuf4Ho+ivwo4DQfBLHEO9gt77Sdwm0b pltEjSQ1NDrnl8Fvk/euho0rIgcKzF57Jw5T5kCXFd7XIvqsDA9 Received: from fruit.crustytoothpaste.net (unknown [IPv6:2607:f2c0:f00f:f901:c351:2fb1:6e4f:b4fb]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by complex.crustytoothpaste.net (Postfix) with ESMTPSA id E94362007E; Thu, 17 Jul 2025 21:30:44 +0000 (UTC) Date: Thu, 17 Jul 2025 21:30:43 +0000 From: "brian m. carlson" To: Ezekiel Newren via GitGitGadget Cc: git@vger.kernel.org, Elijah Newren , Ezekiel Newren Subject: Re: [PATCH 1/7] xdiff: introduce rust Message-ID: Mail-Followup-To: "brian m. carlson" , Ezekiel Newren via GitGitGadget , git@vger.kernel.org, Elijah Newren , Ezekiel Newren References: <2a1f4be13dfbdee21811b7a4907f99042c791c2d.1752784344.git.gitgitgadget@gmail.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VL/82/CobagN8I0X" Content-Disposition: inline In-Reply-To: <2a1f4be13dfbdee21811b7a4907f99042c791c2d.1752784344.git.gitgitgadget@gmail.com> User-Agent: Mutt/2.2.13 (2024-03-09) --VL/82/CobagN8I0X Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2025-07-17 at 20:32:18, Ezekiel Newren via GitGitGadget wrote: > diff --git a/rust/Cargo.lock b/rust/Cargo.lock > new file mode 100644 > index 000000000000..fb1eac690b39 > --- /dev/null > +++ b/rust/Cargo.lock > @@ -0,0 +1,14 @@ > +# This file is automatically @generated by Cargo. > +# It is not intended for manual editing. > +version =3D 4 > + > +[[package]] > +name =3D "interop" > +version =3D "0.1.0" > + > +[[package]] > +name =3D "xdiff" > +version =3D "0.1.0" > +dependencies =3D [ > + "interop", > +] I would prefer that we not check in Cargo.lock in Git. Part of the reason is that it changes across versions and so building with a different version of the toolchain can update the file. In addition, as I mentioned downthread, because our intention is to support the Debian stable toolchain for a year after the new stable release, unless we are exceptionally careful about dependencies, we may end up with a case where distros need to use older dependencies patched for security but other users may want to update the versions to newer dependencies with security fixes but that do not work on our pinned Rust version. We can't possibly satisfy both sets of people if we pin dependencies in Cargo.lock, so we probably want to avoid checking it in and ignore it instead. --=20 brian m. carlson (they/them) Toronto, Ontario, CA --VL/82/CobagN8I0X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.4.7 (GNU/Linux) iHUEABYKAB0WIQQILOaKnbxl+4PRw5F8DEliiIeigQUCaHlrgwAKCRB8DEliiIei gZd8AQD1hzZnTT/48NoSvvpe6P7unigr75xMBJULIwYpOO0z8AD/dLag0X5CV7M+ VqpPXPO8AfP88QLXrFsf01Uwagze3gI= =dEk8 -----END PGP SIGNATURE----- --VL/82/CobagN8I0X--