git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Mihail Malinouski via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Mihail Malinouski <m.l.malinouski@gmail.com>
Subject: Re: [PATCH] docs: fix typo in worktree.adoc 'extension'
Date: Mon, 4 Aug 2025 10:05:29 +0200	[thread overview]
Message-ID: <aJBpyYIFR-JLzu8e@pks.im> (raw)
In-Reply-To: <pull.1936.git.1754291811503.gitgitgadget@gmail.com>

On Mon, Aug 04, 2025 at 07:16:51AM +0000, Mihail Malinouski via GitGitGadget wrote:
> From: M-L-Ml <m.l.malinouski@gmail.com>

The "From" header and the Signed-off-by line need to match.

> The documentation incorrectly referred to the extension without an 's'.
> This fixes the typo for clarity.
> 
> CC: m.l.malinouski@gmail.com

This trailer is nothing we typically want to commit into our history.

> Signed-off-by: Mikhail Malinouski <m.l.malinouski@gmail.com>
> ---
>     should be 's' on the end of the "extension" in the docs Update work…
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1936%2FM-L-Ml%2Fpatch-1-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1936/M-L-Ml/patch-1-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1936
> 
>  Documentation/config/worktree.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/config/worktree.adoc b/Documentation/config/worktree.adoc
> index 5e35c7d018a..9e3f84f748c 100644
> --- a/Documentation/config/worktree.adoc
> +++ b/Documentation/config/worktree.adoc
> @@ -15,5 +15,5 @@ worktree.useRelativePaths::
>  	different locations or environments. Defaults to "false".
>  +
>  Note that setting `worktree.useRelativePaths` to "true" implies enabling the
> -`extension.relativeWorktrees` config (see linkgit:git-config[1]),
> +`extensions.relativeWorktrees` config (see linkgit:git-config[1]),
>  thus making it incompatible with older versions of Git.

The fix itself looks obviously correct to me.

Thanks!

Patrick

  reply	other threads:[~2025-08-04  8:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04  7:16 [PATCH] docs: fix typo in worktree.adoc 'extension' Mihail Malinouski via GitGitGadget
2025-08-04  8:05 ` Patrick Steinhardt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-09-03 14:50 Mihail Malinouski via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJBpyYIFR-JLzu8e@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=m.l.malinouski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).