From: Patrick Steinhardt <ps@pks.im>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3 1/2] t5516: remove surrounding empty lines in test bodies
Date: Wed, 6 Aug 2025 08:14:32 +0200 [thread overview]
Message-ID: <aJLyyPpvlFjwBCIA@pks.im> (raw)
In-Reply-To: <82b09af4ca8e610dd06b94be560622837a35d3ff.1754455931.git.liu.denton@gmail.com>
On Tue, Aug 05, 2025 at 09:53:39PM -0700, Denton Liu wrote:
> This style with the empty lines in test bodies was from when the test
> suite was being developed. Remove the empty lines to match the modern
> test style.
Thanks for going the extra mile. Tacking on while-at-it fixes like this
is what ensures that overall the Git codebase is trending towards our
modern code style.
Patrick
next prev parent reply other threads:[~2025-08-06 6:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 9:42 [PATCH 0/2] remote.c: remove erroneous BUG case Denton Liu
2025-08-04 9:43 ` [PATCH 1/2] t5516: introduce 'push ref expression with non-existent oid src' Denton Liu
2025-08-04 9:43 ` [PATCH 2/2] remote.c: remove BUG in show_push_unqualified_ref_name_error() Denton Liu
2025-08-04 14:19 ` Junio C Hamano
2025-08-05 6:24 ` [PATCH v2 0/2] *** SUBJECT HERE *** Denton Liu
2025-08-05 6:24 ` [PATCH v2 1/2] t5516: introduce 'push ref expression with non-existent oid src' Denton Liu
2025-08-05 13:28 ` Patrick Steinhardt
2025-08-05 17:12 ` Junio C Hamano
2025-08-05 6:24 ` [PATCH v2 2/2] remote.c: remove BUG in show_push_unqualified_ref_name_error() Denton Liu
2025-08-05 13:27 ` Patrick Steinhardt
2025-08-06 4:53 ` [PATCH v3 0/2] remote.c: remove erroneous BUG case Denton Liu
2025-08-06 4:53 ` [PATCH v3 1/2] t5516: remove surrounding empty lines in test bodies Denton Liu
2025-08-06 6:14 ` Patrick Steinhardt [this message]
2025-08-06 4:53 ` [PATCH v3 2/2] remote.c: remove BUG in show_push_unqualified_ref_name_error() Denton Liu
2025-08-06 6:14 ` Patrick Steinhardt
2025-08-06 15:17 ` Junio C Hamano
2025-08-07 4:30 ` [PATCH] remote.c: convert if-else tower to switch Denton Liu
2025-08-07 4:38 ` Patrick Steinhardt
2025-08-07 9:20 ` [PATCH v2] " Denton Liu
2025-08-07 12:35 ` Ben Knoble
2025-08-07 17:19 ` Eric Sunshine
2025-08-07 15:02 ` [PATCH] " Junio C Hamano
2025-08-08 4:41 ` [PATCH v4 0/3] remote.c: remove erroneous BUG case Denton Liu
2025-08-08 4:41 ` [PATCH v4 1/3] t5516: remove surrounding empty lines in test bodies Denton Liu
2025-08-08 4:41 ` [PATCH v4 2/3] remote.c: convert if-else ladder to switch Denton Liu
2025-08-08 5:43 ` Patrick Steinhardt
2025-08-08 7:14 ` Denton Liu
2025-08-08 4:41 ` [PATCH v4 3/3] remote.c: remove BUG in show_push_unqualified_ref_name_error() Denton Liu
2025-08-08 7:24 ` [PATCH v5 0/3] remote.c: remove erroneous BUG case Denton Liu
2025-08-08 7:24 ` [PATCH v5 1/3] t5516: remove surrounding empty lines in test bodies Denton Liu
2025-08-08 7:24 ` [PATCH v5 2/3] remote.c: remove BUG in show_push_unqualified_ref_name_error() Denton Liu
2025-08-08 7:24 ` [PATCH v5 3/3] remote.c: convert if-else ladder to switch Denton Liu
2025-08-08 7:28 ` [PATCH v5 0/3] remote.c: remove erroneous BUG case Patrick Steinhardt
2025-08-08 16:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJLyyPpvlFjwBCIA@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).