From: Patrick Steinhardt <ps@pks.im>
To: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Cc: git@vger.kernel.org, karthik.188@gmail.com
Subject: Re: [GSoC PATCH 2/2] repo: add the field objects.format
Date: Thu, 21 Aug 2025 12:29:31 +0200 [thread overview]
Message-ID: <aKb1Cw-SuS2t0CqG@pks.im> (raw)
In-Reply-To: <20250820144247.79197-3-lucasseikioshiro@gmail.com>
On Wed, Aug 20, 2025 at 11:42:47AM -0300, Lucas Seiki Oshiro wrote:
> diff --git a/builtin/repo.c b/builtin/repo.c
> index b2ec66e454..71ddc5e8c6 100644
> --- a/builtin/repo.c
> +++ b/builtin/repo.c
> @@ -49,6 +55,7 @@ static int get_references_format(struct repository *repo, struct strbuf *buf)
> static const struct field repo_info_fields[] = {
> { "layout.bare", get_layout_bare },
> { "layout.shallow", get_layout_shallow },
> + { "objects.format", get_objects_format},
There's a missing space here before the closing curly brace. Other than
that this patch looks good to me.
Thanks!
Patrick
next prev parent reply other threads:[~2025-08-21 10:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 14:42 [GSoC PATCH 0/2] repo: add -z and objects.format Lucas Seiki Oshiro
2025-08-20 14:42 ` [GSoC PATCH 1/2] repo: add the flag -z as an alias for --format=nul Lucas Seiki Oshiro
2025-08-21 10:12 ` Karthik Nayak
2025-08-21 16:09 ` Junio C Hamano
2025-08-21 16:52 ` Karthik Nayak
2025-08-21 10:29 ` Patrick Steinhardt
2025-08-21 13:29 ` Lucas Seiki Oshiro
2025-08-21 17:28 ` Junio C Hamano
2025-08-21 20:57 ` Lucas Seiki Oshiro
2025-08-21 21:50 ` Junio C Hamano
2025-08-21 18:23 ` Jean-Noël AVILA
2025-08-21 19:52 ` Junio C Hamano
2025-08-20 14:42 ` [GSoC PATCH 2/2] repo: add the field objects.format Lucas Seiki Oshiro
2025-08-21 10:29 ` Patrick Steinhardt [this message]
2025-08-21 19:44 ` Junio C Hamano
2025-08-26 14:51 ` Lucas Seiki Oshiro
2025-08-21 10:14 ` [GSoC PATCH 0/2] repo: add -z and objects.format Karthik Nayak
2025-08-21 16:12 ` Junio C Hamano
2025-08-21 10:29 ` Patrick Steinhardt
2025-08-21 13:23 ` Lucas Seiki Oshiro
2025-08-21 14:55 ` Patrick Steinhardt
2025-08-21 17:28 ` Junio C Hamano
2025-08-26 18:13 ` Lucas Seiki Oshiro
2025-08-26 18:32 ` [GSoC PATCH v2 " Lucas Seiki Oshiro
2025-08-26 18:32 ` [GSoC PATCH v2 1/2] repo: add the flag -z as an alias for --format=nul Lucas Seiki Oshiro
2025-08-28 23:08 ` Junio C Hamano
2025-09-01 13:50 ` Lucas Seiki Oshiro
2025-08-26 18:32 ` [GSoC PATCH v2 2/2] repo: add the field objects.format Lucas Seiki Oshiro
2025-09-01 17:27 ` [GSoC PATCH v3 0/2] repo: add -z and objects.format Lucas Seiki Oshiro
2025-09-01 17:27 ` [GSoC PATCH v3 1/2] repo: add the flag -z as an alias for --format=nul Lucas Seiki Oshiro
2025-09-02 16:21 ` Junio C Hamano
2025-09-02 21:51 ` Lucas Seiki Oshiro
2025-09-01 17:27 ` [GSoC PATCH v3 2/2] repo: add the field objects.format Lucas Seiki Oshiro
2025-09-04 13:40 ` [GSoC PATCH v4 0/2] repo: add -z and objects.format Lucas Seiki Oshiro
2025-09-04 13:40 ` [GSoC PATCH v4 1/2] repo: add the flag -z as an alias for --format=nul Lucas Seiki Oshiro
2025-09-04 13:40 ` [GSoC PATCH v4 2/2] repo: add the field objects.format Lucas Seiki Oshiro
2025-09-04 18:40 ` [GSoC PATCH v4 0/2] repo: add -z and objects.format Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKb1Cw-SuS2t0CqG@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=lucasseikioshiro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).