From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Simon Richter <Simon.Richter@hogyros.de>
Cc: git <git@vger.kernel.org>
Subject: Re: git: prepare to regularly change hashsums
Date: Thu, 21 Aug 2025 08:28:45 +0000 [thread overview]
Message-ID: <aKbYvbWWL0FGXpG7@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <e069a7ca-fba4-432a-9a05-a68b2b6ddbc7@hogyros.de>
[-- Attachment #1: Type: text/plain, Size: 2042 bytes --]
On 2025-08-20 at 05:55:43, Simon Richter wrote:
> On 8/20/25 6:18 AM, brian m. carlson wrote:
>
> > There are many fewer places where we have hard-coded hash values in the
> > tests and a lot more places where we compute values (for instance, if
> > what the test wants to know is that we're three commits before HEAD,
> > then we write `HEAD~3` instead of a specific object ID). Instead of
> > lots of hard-coded 20- and 40-based constants throughout the code, we
> > have a few #define constants and a hash algorithm abstraction.
>
> For me it would be great to still be able to use commit IDs in this way in
> the future.
You can continue to do use object IDs for this purpose: we're not
removing them or deprecating them in any way. It's merely that for our
testsuite we're relying less on object IDs to make it less brittle.
> So if the hash algorithm changes I need to either still be able to make
> ancestor tests using the old IDs, or a quick way to convert them.
Existing repositories will continue to use SHA-1 unless you actively
convert them. The change is simply that _new_ repositories will use
SHA-256 by default (again, you can say that you want to use SHA-1 for a
new repository, just as you can say you want to use SHA-256 now).
I am working on code for interoperability between the two algorithms
which will allow you to convert a repository simply by cloning into a
repository using both hash algorithms. That is, the remote might be
SHA-1, but your repository will have SHA-256 with SHA-1 compatibility
enabled, and then you'll have both algorithms. You'll be able to look
up SHA-1 object IDs in that repository very similarly to SHA-256 object
IDs and convert the two.
That code already exists and works if your repositories are not using
shallow clone, partial clone, or submodules. It just has yet to be sent
upstream. I need to improve a few things in the current status quo
before I can send out the series.
--
brian m. carlson (they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2025-08-21 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 14:25 git: prepare to regularly change hashsums Askar Safin
2025-08-19 21:18 ` brian m. carlson
2025-08-20 5:55 ` Simon Richter
2025-08-21 8:28 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKbYvbWWL0FGXpG7@fruit.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=Simon.Richter@hogyros.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).