git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Meet Soni <meetsoni3017@gmail.com>
Cc: git@vger.kernel.org, shejialuo@gmail.com
Subject: Re: [GSoC][PATCH 0/2] Add refs exists subcommand
Date: Thu, 21 Aug 2025 12:21:46 +0200	[thread overview]
Message-ID: <aKbzOuB0wL17Jhxb@pks.im> (raw)
In-Reply-To: <20250821085246.929307-1-meetsoni3017@gmail.com>

On Thu, Aug 21, 2025 at 02:22:44PM +0530, Meet Soni wrote:
> This series introduces `git refs exists` as a modern replacement for
> `git show-ref --exists`, continuing the effort to consolidate commands
> under the `git refs` namespace.
> 
> The two patches are as follows:
> 
> 1. The first implements the `exists` subcommand. The small amount of
>    logic is duplicated from `show-ref` to avoid unnecessary abstraction.
> 
> 2. The second adds tests by refactoring the `show-ref --exists` tests
>    into a shareable helper, ensuring both commands are tested for
>    identical behavior.
> 
> Meet Soni (2):
>   builtin/refs: add 'exists' subcommand
>   t: add test for git refs exists subcommand
> 
>  Documentation/git-refs.adoc |  7 ++++
>  builtin/refs.c              | 48 +++++++++++++++++++++++++++
>  t/meson.build               |  3 +-
>  t/show-ref-exists-tests.sh  | 66 +++++++++++++++++++++++++++++++++++++
>  t/t1403-show-ref.sh         | 66 +------------------------------------
>  t/t1462-refs-exists.sh      | 22 +++++++++++++
>  6 files changed, 146 insertions(+), 66 deletions(-)
>  create mode 100644 t/show-ref-exists-tests.sh
>  create mode 100755 t/t1462-refs-exists.sh
> 
> 
> base-commit: c44beea485f0f2feaf460e2ac87fdd5608d63cf0
> prerequisite-patch-id: 235cc677f372e9571dade4313f8cfed4eab65f7f
> prerequisite-patch-id: d0cb9932dcf233b3a26e413514375191ede93c73
> prerequisite-patch-id: 9cb324ad34a786af110e9d3d47e4ca8aec240971
> prerequisite-patch-id: 0d74ac673c285c334adcc19b9ca2d4919563e804
> prerequisite-patch-id: 04c6d989f4130a063bc80f7dc9ce9a16d3459665
> prerequisite-patch-id: 95dafb2692da02d79c59cc2742258a915da25e88
> prerequisite-patch-id: f14c9a47038305eb3cfe8e9b649fa64065ada9cd
...

Feels like something went wrong here :)

What the cover letter doesn't mention explicitly is what the base of
this topic is. I assume it's probably v2.51.0 with ms/refs-list merged
into it?

Patrick

  parent reply	other threads:[~2025-08-21 10:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21  8:52 [GSoC][PATCH 0/2] Add refs exists subcommand Meet Soni
2025-08-21  8:52 ` [GSoC][PATCH 1/2] builtin/refs: add 'exists' subcommand Meet Soni
2025-08-21 10:21   ` Patrick Steinhardt
2025-08-21  8:52 ` [GSoC][PATCH 2/2] t: add test for git refs exists subcommand Meet Soni
2025-08-21 10:21   ` Patrick Steinhardt
2025-08-22  4:59     ` Meet Soni
2025-08-21 10:21 ` Patrick Steinhardt [this message]
2025-08-21 16:01 ` [GSoC][PATCH 0/2] Add " Junio C Hamano
2025-08-22  4:27   ` Meet Soni
2025-08-23  6:00 ` [GSoC][PATCH v2 0/4] " Meet Soni
2025-08-23  6:00   ` [GSoC][PATCH v2 1/4] builtin/refs: add 'exists' subcommand Meet Soni
2025-08-23  6:00   ` [GSoC][PATCH v2 2/4] t1403: split 'show-ref --exists' tests into a separate file Meet Soni
2025-08-23  6:00   ` [GSoC][PATCH v2 3/4] t1422: refactor tests to be shareable Meet Soni
2025-08-24 16:58     ` Patrick Steinhardt
2025-08-23  6:00   ` [GSoC][PATCH v2 4/4] t: add test for git refs exists subcommand Meet Soni
2025-08-24 16:58   ` [GSoC][PATCH v2 0/4] Add " Patrick Steinhardt
2025-08-26  6:41   ` [GSoC][PATCH v3 " Meet Soni
2025-08-26  6:41     ` [GSoC][PATCH v3 1/4] builtin/refs: add 'exists' subcommand Meet Soni
2025-08-26  6:41     ` [GSoC][PATCH v3 2/4] t1403: split 'show-ref --exists' tests into a separate file Meet Soni
2025-08-26  6:41     ` [GSoC][PATCH v3 3/4] t1422: refactor tests to be shareable Meet Soni
2025-08-26  6:41     ` [GSoC][PATCH v3 4/4] t: add test for git refs exists subcommand Meet Soni
2025-09-02 11:52     ` [GSoC][PATCH v3 0/4] Add " Patrick Steinhardt
2025-09-02 16:57     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKbzOuB0wL17Jhxb@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=meetsoni3017@gmail.com \
    --cc=shejialuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).