From: shejialuo <shejialuo@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 1/4] string-list: allow passing NULL for `get_entry_index`
Date: Mon, 8 Sep 2025 00:40:26 +0800 [thread overview]
Message-ID: <aL21eowK8MwmDX11@ArchLinux> (raw)
Callers of `get_entry_index()` are required to pass a non-NULL
`exact_match` parameter to receive information about whether an exact
match is found. However, in some cases, callers only need the index
position.
Let's allow callers to pass NULL for the `exact_match` parameter
when they don't need this information, reducing unnecessary variable
declarations in calling code.
Signed-off-by: shejialuo <shejialuo@gmail.com>
---
string-list.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/string-list.c b/string-list.c
index 343cf1ca90..bf358d1a5c 100644
--- a/string-list.c
+++ b/string-list.c
@@ -29,12 +29,14 @@ static size_t get_entry_index(const struct string_list *list, const char *string
else if (compare > 0)
left = middle + 1;
else {
- *exact_match = 1;
+ if (exact_match)
+ *exact_match = 1;
return middle;
}
}
- *exact_match = 0;
+ if (exact_match)
+ *exact_match = 0;
return right;
}
--
2.51.0
next reply other threads:[~2025-09-07 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 16:40 shejialuo [this message]
2025-09-08 16:48 ` [PATCH 1/4] string-list: allow passing NULL for `get_entry_index` Junio C Hamano
2025-09-10 0:09 ` Ben Knoble
2025-09-10 1:32 ` Junio C Hamano
2025-09-10 2:04 ` Ben Knoble
2025-09-15 12:08 ` shejialuo
-- strict thread matches above, loose matches on Subject: below --
2025-09-07 16:40 [PATCH 0/4] enhance string-list API to fix sign compare warnings shejialuo
2025-09-07 16:42 ` [PATCH 1/4] string-list: allow passing NULL for `get_entry_index` shejialuo
2025-09-09 6:22 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL21eowK8MwmDX11@ArchLinux \
--to=shejialuo@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).