git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Meet Soni <meetsoni3017@gmail.com>
Cc: git@vger.kernel.org, shejialuo@gmail.com
Subject: Re: [GSoC][PATCH 3/5] builtin/refs: add optimize subcommand
Date: Tue, 2 Sep 2025 12:18:07 +0200	[thread overview]
Message-ID: <aLbEX-f8LGEFO13C@pks.im> (raw)
In-Reply-To: <20250826073645.1074397-4-meetsoni3017@gmail.com>

On Tue, Aug 26, 2025 at 01:06:43PM +0530, Meet Soni wrote:
> diff --git a/Documentation/git-refs.adoc b/Documentation/git-refs.adoc
> index e608980711..121a2fbeff 100644
> --- a/Documentation/git-refs.adoc
> +++ b/Documentation/git-refs.adoc
> @@ -18,6 +18,7 @@ git refs list [--count=<count>] [--shell|--perl|--python|--tcl]
>  		   [--contains[=<object>]] [--no-contains[=<object>]]
>  		   [(--exclude=<pattern>)...] [--start-after=<marker>]
>  		   [ --stdin | <pattern>... ]
> +git refs optimize [--all] [--no-prune] [--auto] [--include <pattern>] [--exclude <pattern>]
>  
>  DESCRIPTION
>  -----------
> @@ -38,6 +39,11 @@ list::
>  	formatting, and sorting. This subcommand is an alias for
>  	linkgit:git-for-each-ref[1] and offers identical functionality.
>  
> +optimize::
> +        Pack references into a single file to improve repository performance
> +        and reduce storage usage. This subcommand is an alias for
> +        linkgit:git-pack-refs[1] and offers identical functionality.

This feels way too specific to the "files" backend. We do pack
references there, but with the "reftable" backend we don't. Furthermore,
there is no guarantee that we'll only have a single file after
optimizing the store with either of the backends.

So this should be rephrased to become agnostic of the actual backend
that is in use. Maybe just say something like "Optimizes references to
improve repository performance and reduce disk usage."

Patrick

  reply	other threads:[~2025-09-02 10:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26  7:36 [GSoC][PATCH 0/5] Add refs optimize subcommand Meet Soni
2025-08-26  7:36 ` [GSoC][PATCH 1/5] builtin/pack-refs: factor out core logic into a helper Meet Soni
2025-09-02 10:18   ` Patrick Steinhardt
2025-09-03  3:56     ` Meet Soni
2025-09-03  4:37       ` Patrick Steinhardt
2025-09-03  5:25     ` Junio C Hamano
2025-09-03  6:00       ` Patrick Steinhardt
2025-09-03 18:20         ` Junio C Hamano
2025-08-26  7:36 ` [GSoC][PATCH 2/5] doc: factor out common option Meet Soni
2025-08-26  7:36 ` [GSoC][PATCH 3/5] builtin/refs: add optimize subcommand Meet Soni
2025-09-02 10:18   ` Patrick Steinhardt [this message]
2025-08-26  7:36 ` [GSoC][PATCH 4/5] t0601: refactor tests to be shareable Meet Soni
2025-08-26  7:36 ` [GSoC][PATCH 5/5] t: add test for git refs optimize subcommand Meet Soni
2025-08-26 15:18   ` shejialuo
2025-08-31  6:20     ` Meet Soni
2025-09-02 10:18   ` Patrick Steinhardt
2025-09-03  3:58     ` Meet Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLbEX-f8LGEFO13C@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=meetsoni3017@gmail.com \
    --cc=shejialuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).