From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH 1/3] meson: introduce a "docs" alias to compile documentation only
Date: Tue, 16 Sep 2025 11:55:21 +0200 [thread overview]
Message-ID: <aMk0CdaN8pzEPf7m@pks.im> (raw)
In-Reply-To: <CAOLa=ZRVaBp6DAM4gYXFjCRORYxObvWn5egrPAOcGZ42mxnsgg@mail.gmail.com>
On Tue, Sep 16, 2025 at 04:14:56AM -0500, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/meson.build b/meson.build
> > index b3dfcc0497..40b2a2dc54 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -2101,11 +2101,18 @@ endif
> >
> > subdir('bin-wrappers')
> > if get_option('docs') != []
> > + doc_targets = []
> > subdir('Documentation')
> > endif
> >
> > subdir('contrib')
> >
> > +# Note that the target is intentionally configured after including the
> > +# 'contrib' directory, as some tool there also have their own manpages.
> > +if get_option('docs') != []
> > + alias_target('docs', doc_targets)
> > +endif
> > +
>
> Shouldn't we also add it to 'meson_options.txt' with default set to
> true? That would ensure that `meson compile` would also build the docs.
We already have the "docs" option in "meson_options.txt". In fact, it is
not even possible to have an option that is _not_ declared in that file
:)
The option accepts an array of choices, where the choices can be "man"
or "html" to build manpages, HTML sites, both or none. So as soon as the
user made at least one choice we enable the "docs" target automatically.
Patrick
next prev parent reply other threads:[~2025-09-16 9:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 9:16 [PATCH 0/3] ci: don't compile whole project when testing docs with Meson Patrick Steinhardt
2025-09-11 9:16 ` [PATCH 1/3] meson: introduce a "docs" alias to compile documentation only Patrick Steinhardt
2025-09-16 9:14 ` Karthik Nayak
2025-09-16 9:55 ` Patrick Steinhardt [this message]
2025-09-16 11:50 ` Karthik Nayak
2025-09-11 9:16 ` [PATCH 2/3] meson: print docs backend as part of the summary Patrick Steinhardt
2025-09-11 9:16 ` [PATCH 3/3] ci: don't compile whole project when testing docs with Meson Patrick Steinhardt
2025-09-16 9:16 ` Karthik Nayak
2025-09-11 17:02 ` [PATCH 0/3] " Junio C Hamano
2025-09-15 6:04 ` Patrick Steinhardt
2025-09-15 23:13 ` Junio C Hamano
2025-09-16 6:41 ` Patrick Steinhardt
2025-09-16 16:24 ` Junio C Hamano
2025-09-16 9:17 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMk0CdaN8pzEPf7m@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).