git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH 0/3] ci: don't compile whole project when testing docs with Meson
Date: Tue, 16 Sep 2025 08:41:26 +0200	[thread overview]
Message-ID: <aMkGluKUBfq6VNOQ@pks.im> (raw)
In-Reply-To: <xmqqcy7re2df.fsf@gitster.g>

On Mon, Sep 15, 2025 at 04:13:00PM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> >> I wonder if we want to let people say "meson compile doc" to match
> >> the other world?
> >> 
> >> Will queue.  Thanks.
> >
> > The reason why I picked 'docs' is that the accompanying user-facing
> > option is also named the same way. It's thus a bit more consistent with
> > itself to call the target 'docs' as well.
> 
> Sorry, but I am not sure what user-facing "docs" option you are
> referring to; is this some earlier mistake we made that is way too
> entrenched to fix?  I do know about the "make docs" that barfs with
> "*** No rule to make target 'docs'.  Stop.", and I would call it
> user-facing.  I would say it is a bit too old to "correct" without
> disrupting existing users.

I meant the Meson option `-Ddocs=man,html`. I feel it's more natural
there if the accompanying target is also called "docs" there.

Another option is that we could also just have both. In that case users
of the Makefile could continue to use the "doc" target with Meson, as
they are used to. And users that are used to Meson can use the "docs"
target.

Patrick

  reply	other threads:[~2025-09-16  6:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11  9:16 [PATCH 0/3] ci: don't compile whole project when testing docs with Meson Patrick Steinhardt
2025-09-11  9:16 ` [PATCH 1/3] meson: introduce a "docs" alias to compile documentation only Patrick Steinhardt
2025-09-16  9:14   ` Karthik Nayak
2025-09-16  9:55     ` Patrick Steinhardt
2025-09-16 11:50       ` Karthik Nayak
2025-09-11  9:16 ` [PATCH 2/3] meson: print docs backend as part of the summary Patrick Steinhardt
2025-09-11  9:16 ` [PATCH 3/3] ci: don't compile whole project when testing docs with Meson Patrick Steinhardt
2025-09-16  9:16   ` Karthik Nayak
2025-09-11 17:02 ` [PATCH 0/3] " Junio C Hamano
2025-09-15  6:04   ` Patrick Steinhardt
2025-09-15 23:13     ` Junio C Hamano
2025-09-16  6:41       ` Patrick Steinhardt [this message]
2025-09-16 16:24         ` Junio C Hamano
2025-09-16  9:17 ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMkGluKUBfq6VNOQ@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).