From: shejialuo <shejialuo@gmail.com>
To: Meet Soni <meetsoni3017@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im, gitster@pobox.com
Subject: Re: [GSoC][PATCH v3 4/9] builtin/pack-refs: convert to use the generic refs_optimize() API
Date: Thu, 18 Sep 2025 18:43:50 +0800 [thread overview]
Message-ID: <aMviZmilaxXb2a35@ArchLinux> (raw)
In-Reply-To: <20250918054704.544254-5-meetsoni3017@gmail.com>
On Thu, Sep 18, 2025 at 11:16:59AM +0530, Meet Soni wrote:
> The `git pack-refs` command is tied to the 'files' reference backend. In
> a repository that uses a different backend (like 'reftable'), the
> command is a no-op.
>
I think `git pack-refs` would work for reftable backend. It would
eventually call `reftable_be_pack_refs`. And from my intuitive
understanding, it would compact the reftable to reduce the size of the
table.
> To make `git pack-refs` a truly generic frontend for reference
> optimization, refactor it to use the new generic `refs_optimize()` API.
> This will allow the command to automatically work with any backend
> that implements the `optimize` action in the future.
>
If my above understanding is correct, "git pack-refs" has already worked
with all the backends. But for reftable backend, the semantic of
"pack-refs" is not clear, optimize is a much better semantic word.
Thanks,
Jialuo
next prev parent reply other threads:[~2025-09-18 10:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 7:51 [GSoC][PATCH v2 0/5] Add refs optimize subcommand Meet Soni
2025-09-06 7:51 ` [GSoC][PATCH v2 1/5] builtin/pack-refs: factor out core logic into a shared library Meet Soni
2025-09-06 7:51 ` [GSoC][PATCH v2 2/5] doc: factor out common option Meet Soni
2025-09-08 16:44 ` Junio C Hamano
2025-09-06 7:51 ` [GSoC][PATCH v2 3/5] builtin/refs: add optimize subcommand Meet Soni
2025-09-06 7:51 ` [GSoC][PATCH v2 4/5] t0601: refactor tests to be shareable Meet Soni
2025-09-06 7:51 ` [GSoC][PATCH v2 5/5] t: add test for git refs optimize subcommand Meet Soni
2025-09-08 14:07 ` [GSoC][PATCH v2 0/5] Add " Junio C Hamano
2025-09-08 16:41 ` Junio C Hamano
2025-09-18 5:46 ` [GSoC][PATCH v3 0/9] " Meet Soni
2025-09-18 5:46 ` [GSoC][PATCH v3 1/9] refs: add a generic 'optimize' API Meet Soni
2025-09-18 10:44 ` shejialuo
2025-09-18 15:39 ` Junio C Hamano
2025-09-18 5:46 ` [GSoC][PATCH v3 2/9] files-backend: implement 'optimize' action Meet Soni
2025-09-18 5:46 ` [GSoC][PATCH v3 3/9] reftable-backend: " Meet Soni
2025-09-18 5:46 ` [GSoC][PATCH v3 4/9] builtin/pack-refs: convert to use the generic refs_optimize() API Meet Soni
2025-09-18 10:43 ` shejialuo [this message]
2025-09-18 5:47 ` [GSoC][PATCH v3 5/9] builtin/pack-refs: factor out core logic into a shared library Meet Soni
2025-09-18 5:47 ` [GSoC][GSoC][PATCH v3 6/9] doc: pack-refs: factor out common options Meet Soni
2025-09-18 5:47 ` [GSoC][PATCH v3 7/9] builtin/refs: add optimize subcommand Meet Soni
2025-09-18 16:06 ` Junio C Hamano
2025-09-18 5:47 ` [GSoC][PATCH v3 8/9] t0601: refactor tests to be shareable Meet Soni
2025-09-18 5:47 ` [GSoC][PATCH v3 9/9] t: add test for git refs optimize subcommand Meet Soni
2025-09-19 8:26 ` [GSoC][PATCH v4 0/9] Add " Meet Soni
2025-09-19 8:26 ` [GSoC][PATCH v4 1/9] refs: add a generic 'optimize' API Meet Soni
2025-09-24 6:18 ` Patrick Steinhardt
2025-09-19 8:26 ` [GSoC][PATCH v4 2/9] files-backend: implement 'optimize' action Meet Soni
2025-09-19 8:26 ` [GSoC][PATCH v4 3/9] reftable-backend: " Meet Soni
2025-09-19 8:26 ` [GSoC][PATCH v4 4/9] builtin/pack-refs: convert to use the generic refs_optimize() API Meet Soni
2025-09-19 8:26 ` [GSoC][PATCH v4 5/9] builtin/pack-refs: factor out core logic into a shared library Meet Soni
2025-09-24 6:18 ` Patrick Steinhardt
2025-09-19 8:26 ` [GSoC][PATCH v4 6/9] doc: pack-refs: factor out common options Meet Soni
2025-09-19 8:26 ` [GSoC][PATCH v4 7/9] builtin/refs: add optimize subcommand Meet Soni
2025-09-19 8:26 ` [GSoC][PATCH v4 8/9] t0601: refactor tests to be shareable Meet Soni
2025-09-19 8:26 ` [GSoC][PATCH v4 9/9] t: add test for git refs optimize subcommand Meet Soni
2025-09-19 18:43 ` [GSoC][PATCH v4 0/9] Add " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMviZmilaxXb2a35@ArchLinux \
--to=shejialuo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=meetsoni3017@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).