git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: Ezekiel Newren <ezekielnewren@gmail.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	Karthik Nayak <karthik.188@gmail.com>,
	Eric Sunshine <ericsunshine@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Chris Torek <chris.torek@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2 0/6] ci: improvements to our Rust infrastructure
Date: Wed, 8 Oct 2025 14:04:10 +0200	[thread overview]
Message-ID: <aOZTOs5Z9QyfRXYO@pks.im> (raw)
In-Reply-To: <20251008-b4-pks-ci-rust-v2-0-d556ee83c381@pks.im>

On Wed, Oct 08, 2025 at 08:27:11AM +0200, Patrick Steinhardt wrote:
> Hi,
> 
> this small patch series introduces some improvements for our Rust
> infrastructure. Most importantly, it introduces a couple of static
> analysis checks to verify consistent formatting, use Clippy for linting
> and to verify our minimum supported Rust version.
> 
> Furthermore, this series also introduces support for building with Rust
> enabled on Windows.
> 
> The series is built on top of 45547b60ac (Merge branch 'master' of
> https://github.com/j6t/gitk, 2025-10-05) with ps/rust-balloon at
> e425c40aa0 (ci: enable Rust for breaking-changes jobs, 2025-10-02) and
> ps/gitlab-ci-windows-improvements at 3c4925c3f5 (t8020: fix test failure
> due to indeterministic tag sorting, 2025-10-02) merged into it.
> 
> Changes in v2:
>   - Adjust comments for `encode_varint()` and `decode_varint()` based on
>     brian's feedback.
>   - Some small improvements to commit messages.
>   - Not changed is the default column limit used by Rust. I think using
>     the column limit of 100 used by the Rust ecosystem is sensible, but
>     if there is a majority advocating for a limit of 80 I'll adapt this.
>   - Link to v1: https://lore.kernel.org/r/20251007-b4-pks-ci-rust-v1-0-394502abe7ea@pks.im

Sorry, I noticed that threading is broken here. An update of b4 made me
lose my custom patches that implement shallow threading by accident. The
next version will connect back to the original thread again.

Patrick

  parent reply	other threads:[~2025-10-08 12:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08  6:27 [PATCH v2 0/6] ci: improvements to our Rust infrastructure Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 1/6] ci: deduplicate calls to `apt-get update` Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 2/6] ci: check formatting of our Rust code Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 3/6] rust/varint: add safety comments Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 4/6] ci: check for common Rust mistakes via Clippy Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 5/6] ci: verify minimum supported Rust version Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 6/6] rust: support for Windows Patrick Steinhardt
2025-10-08 12:04 ` Patrick Steinhardt [this message]
2025-10-09 19:29 ` [PATCH v2 0/6] ci: improvements to our Rust infrastructure Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOZTOs5Z9QyfRXYO@pks.im \
    --to=ps@pks.im \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=chris.torek@gmail.com \
    --cc=ericsunshine@gmail.com \
    --cc=ezekielnewren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karthik.188@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).