From: Taylor Blau <me@ttaylorr.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/6] packfile: rename `packfile_store_get_all_packs()`
Date: Wed, 8 Oct 2025 16:48:21 -0400 [thread overview]
Message-ID: <aObOFciwYsvTWT0e@nand.local> (raw)
In-Reply-To: <20251007-pks-packfiles-convert-get-all-v1-6-428227657a89@pks.im>
On Tue, Oct 07, 2025 at 02:41:12PM +0200, Patrick Steinhardt wrote:
> ---
> builtin/fast-import.c | 4 ++--
> builtin/pack-objects.c | 4 ++--
> packfile.c | 2 +-
> packfile.h | 4 ++--
> 4 files changed, 7 insertions(+), 7 deletions(-)
Hmm. I wonder if we should perform this step at a later date. My fear is
that another topic in fight might introduce a new use of the "get_packs"
assuming the old semantics.
Merging this topic and that hypothetical one together wouldn't produce a
textual conflict, but it could introduce bugs where the hypothetical new
code expects the old behavior.
Perhaps I'm overthinking this, but figured I'd write down the concern
nonetheless.
Thanks,
Taylor
next prev parent reply other threads:[~2025-10-08 20:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 12:41 [PATCH 0/6] packfile: remove `packfile_store_get_packs()` Patrick Steinhardt
2025-10-07 12:41 ` [PATCH 1/6] object-name: convert to use `packfile_store_get_all_packs()` Patrick Steinhardt
2025-10-08 20:21 ` Taylor Blau
2025-10-07 12:41 ` [PATCH 2/6] builtin/gc: " Patrick Steinhardt
2025-10-08 20:25 ` Taylor Blau
2025-10-09 6:36 ` Patrick Steinhardt
2025-10-07 12:41 ` [PATCH 3/6] builtin/grep: simplify how we preload packs Patrick Steinhardt
2025-10-08 20:43 ` Taylor Blau
2025-10-07 12:41 ` [PATCH 4/6] packfile: drop `packfile_store_get_packs()` Patrick Steinhardt
2025-10-08 20:44 ` Taylor Blau
2025-10-07 12:41 ` [PATCH 5/6] packfile: introduce macro to iterate through packs Patrick Steinhardt
2025-10-08 21:15 ` Taylor Blau
2025-10-09 6:36 ` Patrick Steinhardt
2025-10-07 12:41 ` [PATCH 6/6] packfile: rename `packfile_store_get_all_packs()` Patrick Steinhardt
2025-10-08 20:48 ` Taylor Blau [this message]
2025-10-09 6:36 ` Patrick Steinhardt
2025-10-09 8:01 ` [PATCH v2 0/6] packfile: remove `packfile_store_get_packs()` Patrick Steinhardt
2025-10-09 8:01 ` [PATCH v2 1/6] object-name: convert to use `packfile_store_get_all_packs()` Patrick Steinhardt
2025-10-14 19:07 ` Justin Tobler
2025-10-09 8:01 ` [PATCH v2 2/6] builtin/gc: " Patrick Steinhardt
2025-10-09 8:01 ` [PATCH v2 3/6] builtin/grep: simplify how we preload packs Patrick Steinhardt
2025-10-09 8:01 ` [PATCH v2 4/6] packfile: drop `packfile_store_get_packs()` Patrick Steinhardt
2025-10-14 19:11 ` Justin Tobler
2025-10-09 8:01 ` [PATCH v2 5/6] packfile: introduce macro to iterate through packs Patrick Steinhardt
2025-10-14 19:17 ` Justin Tobler
2025-10-09 8:01 ` [PATCH v2 6/6] packfile: rename `packfile_store_get_all_packs()` Patrick Steinhardt
2025-10-14 19:19 ` [PATCH v2 0/6] packfile: remove `packfile_store_get_packs()` Justin Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aObOFciwYsvTWT0e@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).