git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH 1/2] SubmittingPatches: extend release-notes experiment to topic names
Date: Wed, 8 Oct 2025 17:20:25 -0400	[thread overview]
Message-ID: <aObVmU7m4PahMsEN@nand.local> (raw)
In-Reply-To: <85dbe67e-f252-4548-910d-4af29939806a@app.fastmail.com>

On Wed, Oct 08, 2025 at 06:14:42PM +0200, Kristoffer Haugsbakk wrote:
> > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> > index 86ca7f6a78a..f48688e3700 100644
> > --- a/Documentation/SubmittingPatches
> > +++ b/Documentation/SubmittingPatches
> > @@ -579,14 +579,19 @@ line via `git format-patch --notes`.
> >  [[the-topic-summary]]
> >  *This is EXPERIMENTAL*.
> >
> > -When sending a topic, you can propose a one-paragraph summary that
> > -should appear in the "What's cooking" report when it is picked up to
> > -explain the topic.  If you choose to do so, please write a 2-5 line
> > -paragraph that will fit well in our release notes (see many bulleted
> > -entries in the Documentation/RelNotes/* files for examples), and make
> > -it the first paragraph of the cover letter.  For a single-patch
> > -series, use the space between the three-dash line and the diffstat, as
> > -described earlier.
> > +When sending a topic, you can optionally propose a topic name and/or a
> > +one-paragraph summary that should appear in the "What's cooking"
> > +report when it is picked up to explain the topic.  If you choose to do
> > +so, please write a 2-5 line paragraph that will fit well in our
> > +release notes (see many bulleted entries in the
> > +Documentation/RelNotes/* files for examples), and make it the first
> > +(or second, if including a suggested topic name) paragraph of the
> > +cover letter.  If suggesting a topic name, use the format
> > +"XX/your-topic-name", where "XX" is a stand-in for the primary
> > +author's initials, and "your-topic-name" is a brief, dash-delimited
>
> Is there a precedent for “primary” author? Why not just “author”?
>
> This seems to be referring to the fact that patches might have
> co-authors (trailers) and similar, or that it could be sent from someone
> else but the author, but I don’t think this adjective makes it clear
> that the topic name should stick to the author (in the Git model’s
> sense) name only.

I wrote it this way to account for individuals listed under the
Co-authored-by trailer. I'm not entirely sure that I'm following the
latter half of this sentence. Could you clarify what you mean?

> But it was noted[1] that the-topic-summary doesn’t seem to have been
> used much. That’s not surprising given that the instruction makes
> the-topic-summary blend in with the rest of the cover letter and doesn’t
> signal that the author intends for the first paragraph to be used as
> such. This patch shares the same problem.

That's fair, though I admittedly dislike the idea of prescribing a
format for the cover letter. It should be clear to those (such as the
maintainer) who are reading the cover letter closely whether or not the
first paragraph (or two) are meant to be used as the topic name/summary.

Perhaps I am in the minority in thinking that, though, in which case I
am happy to continue to discuss/explore other options.

Thanks,
Taylor

  parent reply	other threads:[~2025-10-08 21:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07 21:39 [PATCH 0/2] SubmittingPatches: guidance for topic names and multi-series efforts Taylor Blau
2025-10-07 21:39 ` [PATCH 1/2] SubmittingPatches: extend release-notes experiment to topic names Taylor Blau
2025-10-08 16:14   ` Kristoffer Haugsbakk
2025-10-08 20:51     ` Junio C Hamano
2025-10-08 21:24       ` Taylor Blau
2025-10-08 22:03         ` Kristoffer Haugsbakk
2025-10-08 21:20     ` Taylor Blau [this message]
2025-10-08 21:58       ` Kristoffer Haugsbakk
2025-10-07 21:39 ` [PATCH 2/2] SubmittingPatches: guidance for multi-series efforts Taylor Blau
2025-10-08  0:21 ` [PATCH 0/2] SubmittingPatches: guidance for topic names and " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aObVmU7m4PahMsEN@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).