Re: Making git grep ignore binary the default

["brian m. carlson" <sandals@crustytoothpaste.net>]

[-- Attachment #1: Type: text/plain, Size: 2394 bytes --]

On 2025-10-17 at 23:29:22, Thomas Braun wrote:
> Am 17.10.2025 um 23:29 schrieb Junio C Hamano:
> > Simply because we have never needed to do something similar to "-a"
> > and "-I" that we added in early 2006 for the past nearly 20 years.
> > Also because GNU does not have any such thing to force "-a" or "-I"
> > as default.  The biggest reason is that it would be surprising if
> > such a change does not break existing scripts that have been written
> > by people over the years.
> 
> And if we only would have the config option "grep.ignoreBinary" defaulting
> to false with no default change whatsoever? I always want to ignore binaries
> when grepping and find it a bit tedious that I have to spell it out all over
> again. And yes I do have an alias as well but usually don't remember to use
> it.

As Junio said, this could break existing scripts.  If I write a command
which uses `git grep` and expects to find all matching files, it would
not work on your system with `grep.ignoreBinary` set to true.

For instance, if I am working on a project for a company and must
exclude source code with a certain vendor's copyright (because we don't
have permission to distribute their code), then it would be very bad if
I accidentally distributed that company's binary files due to `git grep
-l PATTERN | xargs rm -f` not matching them since it would violate the
license.

This is just an example, but there are lots of cases where people do
really want to search every file.

> I'm also curious what people are looking for in binary files with git grep.

It's common to mark PDFs or PostScript files as binary because they
often contain embedded binary fonts, but they are actually mostly text
and can be usefully searched with grep.  For instance, I once created
some awards for a non-profit based on combining standalone text-based
PostScript code along with output from groff, so those independent
pieces could end up being source that you might store in Git and search,
even if many configurations would use `*.ps -text` in a system
gitattributes file.

Sometimes you also have images or such for a website, which contain XMP
metadata (a form of XML-serialized RDF).  Finding those images which
have certain author metadata or a certain license URL embedded in them
could be valuable.
-- 
brian m. carlson (they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]