From: Todd Zullinger <tmz@pobox.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Andrew Kreimer <algonell@gmail.com>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] t1016: make sure to use specified GPG
Date: Thu, 23 Oct 2025 21:52:29 -0400 [thread overview]
Message-ID: <aPrb3QGTNE7IBClk@teonanacatl.net> (raw)
In-Reply-To: <xmqq3479tk78.fsf@gitster.g>
Junio C Hamano wrote:
> Todd Zullinger <tmz@pobox.com> writes:
>
>> Junio C Hamano wrote:
>>> Todd Zullinger <tmz@pobox.com> writes:
>>>
>>>> Interesting. And well-spotted.
>>>>
>>>> This _does_ seem to resolve the failures in our CI and in
>>>> the Fedora build system. I was able to run a few test
>>>> builds. With this fix, the tests were successful where they
>>>> were not without it.
>>> ...
>>> FWIW, GitHub CI jobs are failing t1016 at the tip of 'seen' (which
>>> has this change), but only some and not all the jobs, which may
>>> indicate there are timeing-dependent flakes involved. I didn't dig
>>> further, though.
>
> Let's merge this fix down, even though it does not seem to have
> any effect improving the situation of flaky tests here.
Sounds good, thanks. It's the right thing to do, even if it
didn't clear up the issues which led to you noticing.
--
Todd
next prev parent reply other threads:[~2025-10-24 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 21:14 [PATCH] t1016: make sure to use specified GPG Junio C Hamano
2025-10-12 14:23 ` Todd Zullinger
2025-10-12 15:11 ` Junio C Hamano
2025-10-12 18:31 ` Todd Zullinger
2025-10-23 20:52 ` Junio C Hamano
2025-10-24 1:52 ` Todd Zullinger [this message]
2025-10-12 20:40 ` Andrew Kreimer
2025-10-13 15:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPrb3QGTNE7IBClk@teonanacatl.net \
--to=tmz@pobox.com \
--cc=algonell@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).