From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, jltobler@gmail.com, gitster@pobox.com
Subject: Re: [PATCH v4 0/5] maintenance: add an 'is-needed' subcommand
Date: Mon, 10 Nov 2025 07:46:17 +0100 [thread overview]
Message-ID: <aRGKMH4Wc7PJ6Z5z@pks.im> (raw)
In-Reply-To: <20251108-562-add-sub-command-to-check-if-maintenance-is-needed-v4-0-a90f229b6023@gmail.com>
On Sat, Nov 08, 2025 at 10:51:52PM +0100, Karthik Nayak wrote:
> Changes in v4:
> - In `update_segment_if_compaction_required()` change the argument name
> from `use_heuristics` to `use_geometric` since we only have one
> heuristic currently and this is much clearer to understand.
> - There were a lot of discussion on how to return a bool variable when
> the function has a return type of int. We discussed both '!!required',
> and 'required != true'. I'm going to punt this discussion keeping it
> simple as 'return required' as in my first version, since even Junio
> expressed his thoughts in favor of it.
> - Add a TODO for improvements to the flow when running `git maintenance
> is-needed` without the `--auto` flag.
> - Link to v3: https://patch.msgid.link/20251106-562-add-sub-command-to-check-if-maintenance-is-needed-v3-0-d611a2a95cf5@gmail.com
I'm happy with this version. Thanks!
Patrick
prev parent reply other threads:[~2025-11-10 6:46 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 14:22 [PATCH 0/5] maintenance: add an 'is-needed' subcommand Karthik Nayak
2025-10-31 14:22 ` [PATCH 1/5] reftable/stack: return stack segments directly Karthik Nayak
2025-10-31 16:22 ` Justin Tobler
2025-11-03 15:05 ` Karthik Nayak
2025-11-03 18:03 ` Justin Tobler
2025-10-31 14:22 ` [PATCH 2/5] reftable/stack: add function to check if optimization is required Karthik Nayak
2025-10-31 17:02 ` Justin Tobler
2025-10-31 18:17 ` Junio C Hamano
2025-11-03 16:20 ` Karthik Nayak
2025-11-03 15:51 ` Karthik Nayak
2025-11-03 17:59 ` Justin Tobler
2025-11-03 14:00 ` Patrick Steinhardt
2025-11-03 16:35 ` Karthik Nayak
2025-10-31 14:22 ` [PATCH 3/5] refs: add a `optimize_required` field to `struct ref_storage_be` Karthik Nayak
2025-10-31 14:22 ` [PATCH 4/5] maintenance: add checking logic in `pack_refs_condition()` Karthik Nayak
2025-11-03 14:00 ` Patrick Steinhardt
2025-11-03 17:04 ` Karthik Nayak
2025-10-31 14:22 ` [PATCH 5/5] maintenance: add 'is-needed' subcommand Karthik Nayak
2025-11-03 14:00 ` Patrick Steinhardt
2025-11-03 17:18 ` Karthik Nayak
2025-11-04 5:54 ` Patrick Steinhardt
2025-11-04 8:28 ` Karthik Nayak
2025-11-04 8:43 ` [PATCH v2 0/5] maintenance: add an " Karthik Nayak
2025-11-04 8:43 ` [PATCH v2 1/5] reftable/stack: return stack segments directly Karthik Nayak
2025-11-04 8:43 ` [PATCH v2 2/5] reftable/stack: add function to check if optimization is required Karthik Nayak
2025-11-04 20:26 ` Junio C Hamano
2025-11-05 14:11 ` Karthik Nayak
2025-11-05 18:10 ` Junio C Hamano
2025-11-06 8:18 ` Karthik Nayak
2025-11-04 8:43 ` [PATCH v2 3/5] refs: add a `optimize_required` field to `struct ref_storage_be` Karthik Nayak
2025-11-04 8:43 ` [PATCH v2 4/5] maintenance: add checking logic in `pack_refs_condition()` Karthik Nayak
2025-11-04 8:44 ` [PATCH v2 5/5] maintenance: add 'is-needed' subcommand Karthik Nayak
2025-11-04 15:43 ` [PATCH v2 0/5] maintenance: add an " Junio C Hamano
2025-11-05 14:00 ` Karthik Nayak
2025-11-06 8:22 ` [PATCH v3 " Karthik Nayak
2025-11-06 8:22 ` [PATCH v3 1/5] reftable/stack: return stack segments directly Karthik Nayak
2025-11-06 8:22 ` [PATCH v3 2/5] reftable/stack: add function to check if optimization is required Karthik Nayak
2025-11-06 18:18 ` Junio C Hamano
2025-11-07 6:06 ` Patrick Steinhardt
2025-11-06 8:22 ` [PATCH v3 3/5] refs: add a `optimize_required` field to `struct ref_storage_be` Karthik Nayak
2025-11-06 8:22 ` [PATCH v3 4/5] maintenance: add checking logic in `pack_refs_condition()` Karthik Nayak
2025-11-06 11:58 ` Patrick Steinhardt
2025-11-06 13:04 ` Karthik Nayak
2025-11-06 15:24 ` Junio C Hamano
2025-11-07 15:58 ` Karthik Nayak
2025-11-07 16:41 ` Junio C Hamano
2025-11-07 15:58 ` Karthik Nayak
2025-11-06 8:22 ` [PATCH v3 5/5] maintenance: add 'is-needed' subcommand Karthik Nayak
2025-11-06 12:02 ` Patrick Steinhardt
2025-11-06 13:07 ` Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 0/5] maintenance: add an " Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 1/5] reftable/stack: return stack segments directly Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 2/5] reftable/stack: add function to check if optimization is required Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 3/5] refs: add a `optimize_required` field to `struct ref_storage_be` Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 4/5] maintenance: add checking logic in `pack_refs_condition()` Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 5/5] maintenance: add 'is-needed' subcommand Karthik Nayak
2025-11-10 6:46 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRGKMH4Wc7PJ6Z5z@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).