From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v1 2/3] Documentation: your checkout directory is "working tree" (part 1)
Date: Wed, 12 Nov 2025 07:41:48 +0100 [thread overview]
Message-ID: <aRQsLNXFdB6KIe0Y@pks.im> (raw)
In-Reply-To: <20251111195853.2511146-3-gitster@pobox.com>
On Tue, Nov 11, 2025 at 11:58:52AM -0800, Junio C Hamano wrote:
> diff --git a/Documentation/git-rev-parse.adoc b/Documentation/git-rev-parse.adoc
> index 5398691f3f..ced73fa8af 100644
> --- a/Documentation/git-rev-parse.adoc
> +++ b/Documentation/git-rev-parse.adoc
> @@ -305,7 +305,7 @@ The following options are unaffected by `--path-format`:
> directory print "true", otherwise "false".
>
> --is-inside-work-tree::
> - When the current working directory is inside the work tree of the
> + When the current working directory is inside the working tree of the
> repository print "true", otherwise "false".
>
> --is-bare-repository::
The option itself is unfortunately misnamed, as well, as it should be
"--is-inside-working-tree". We could of course introduce an alias for
it, but I'm not sure it's worth it. Definitely doesn't have to be part
of this patch series.
Other than that this series looks good to me, and I certainly appreciate
that we're now being more consistent with our own terminology. Thanks!
Patrick
next prev parent reply other threads:[~2025-11-12 6:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 19:58 [PATCH v1 0/3] War on "work tree" Junio C Hamano
2025-11-11 19:58 ` [PATCH v1 1/3] notes doc: call NOTES_MERGE_WORKTREE a "worktree", not " Junio C Hamano
2025-11-11 19:58 ` [PATCH v1 2/3] Documentation: your checkout directory is "working tree" (part 1) Junio C Hamano
2025-11-12 6:41 ` Patrick Steinhardt [this message]
2025-11-11 19:58 ` [PATCH v1 3/3] Documentation: your checkout directory is "working tree" (part 2) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRQsLNXFdB6KIe0Y@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).