From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] config: fix short help of unset flags
Date: Mon, 1 Dec 2025 09:11:13 +0100 [thread overview]
Message-ID: <aS1NoXf4uBHyv13D@pks.im> (raw)
In-Reply-To: <xmqqtsyjujd3.fsf@gitster.g>
On Mon, Nov 24, 2025 at 03:00:08PM -0800, Junio C Hamano wrote:
> René Scharfe <l.s.r@web.de> writes:
>
> > The flags --all and --value of "git config unset" don't make the command
> > "replace" or "show" anything, they are about selecting what to unset.
> > Change their help text accordingly.
>
> Good eyes. Perfectly makes sense. Will queue. Thanks.
Indeed, the patch looks obviously good to me. Thanks for the fixes!
Patrick
prev parent reply other threads:[~2025-12-01 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 21:00 [PATCH] config: fix short help of unset flags René Scharfe
2025-11-24 23:00 ` Junio C Hamano
2025-12-01 8:11 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS1NoXf4uBHyv13D@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).