* [PATCH] test_detect_ref_format: fix comment
@ 2025-12-18 15:20 Johannes Schindelin via GitGitGadget
2025-12-19 6:43 ` Patrick Steinhardt
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2025-12-18 15:20 UTC (permalink / raw)
To: git; +Cc: Patrick Steinhardt, Johannes Schindelin, Johannes Schindelin
From: Johannes Schindelin <johannes.schindelin@gmx.de>
When 58aaf59133b (t: introduce GIT_TEST_DEFAULT_REF_FORMAT envvar,
2023-12-29) copy-edited the `test_detect_hash` function, the code
comment was accidentally left unchanged. Let's adjust it.
Noticed-by: Matthew John Cheetham <mjcheetham@outlook.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
test_detect_ref_format: fix comment
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2019%2Fdscho%2Ffix-detect-ref-format-comment-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2019/dscho/fix-detect-ref-format-comment-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2019
t/test-lib-functions.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index 52d7759bf5..14e238d24d 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -1724,7 +1724,7 @@ test_detect_hash () {
esac
}
-# Detect the hash algorithm in use.
+# Detect the ref format in use.
test_detect_ref_format () {
echo "${GIT_TEST_DEFAULT_REF_FORMAT:-files}"
}
base-commit: c4a0c8845e2426375ad257b6c221a3a7d92ecfda
--
gitgitgadget
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] test_detect_ref_format: fix comment
2025-12-18 15:20 [PATCH] test_detect_ref_format: fix comment Johannes Schindelin via GitGitGadget
@ 2025-12-19 6:43 ` Patrick Steinhardt
0 siblings, 0 replies; 2+ messages in thread
From: Patrick Steinhardt @ 2025-12-19 6:43 UTC (permalink / raw)
To: Johannes Schindelin via GitGitGadget; +Cc: git, Johannes Schindelin
On Thu, Dec 18, 2025 at 03:20:59PM +0000, Johannes Schindelin via GitGitGadget wrote:
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index 52d7759bf5..14e238d24d 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -1724,7 +1724,7 @@ test_detect_hash () {
> esac
> }
>
> -# Detect the hash algorithm in use.
> +# Detect the ref format in use.
> test_detect_ref_format () {
> echo "${GIT_TEST_DEFAULT_REF_FORMAT:-files}"
> }
An obvious copy-paste error indeed. Thanks for fixing, this looks good
to me!
Patrick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-19 6:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-18 15:20 [PATCH] test_detect_ref_format: fix comment Johannes Schindelin via GitGitGadget
2025-12-19 6:43 ` Patrick Steinhardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).